Closed Bug 996518 Opened 8 years ago Closed 8 years ago

Add an extra assert in TypePolicy of MTypeBarrier

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: h4writer, Assigned: h4writer)

Details

Attachments

(1 file)

When a MTypeBarrier is MIRType_Undefined/MIRType_Null or MIRType_Magic the typebarrier is only used to guard the Value. But we cannot unbox the value. So in this case we replace all uses with a MConstant. So such a MTypeBarrier should never have a use!

This was an issue in bug 995076. This extra assert might have made it more obvious as to why we were failing.
Attached patch Add assertSplinter Review
Assignee: nobody → hv1989
Attachment #8406749 - Flags: review?(jdemooij)
Attachment #8406749 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/4ac1f53ee224
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.