Closed
Bug 996518
Opened 10 years ago
Closed 10 years ago
Add an extra assert in TypePolicy of MTypeBarrier
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
863 bytes,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
When a MTypeBarrier is MIRType_Undefined/MIRType_Null or MIRType_Magic the typebarrier is only used to guard the Value. But we cannot unbox the value. So in this case we replace all uses with a MConstant. So such a MTypeBarrier should never have a use! This was an issue in bug 995076. This extra assert might have made it more obvious as to why we were failing.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → hv1989
Attachment #8406749 -
Flags: review?(jdemooij)
Updated•10 years ago
|
Attachment #8406749 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ac1f53ee224
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ac1f53ee224
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•