99652 - parsing invalid frameset values for cols and rows

Status: RESOLVED WORKSFORME

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Johan Zieger]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3) Gecko/20010802
BuildID:    2001090319



Reproducible: Always
Steps to Reproduce:
1.just visit the site
2.
3.

this site was built with Dreamweaver

Comment 1

[Boris Zbarsky [:bzbarsky]]

The problem is the following line:

<frameset cols="no" rows="74,*" frameborder="0" border="0" framespacing="0">

cols="no" is an invalid value... but we seem to be parsing it as a number and
trying to create cols..  ignoring the rows="74,*"

Over to parser

Comment 2

[Ryan Pertusio]

I can't think of an appropriate Summary, but I'm changing it to something a
little bit clearer :)

Old Summary:  "caan't se anything at this website"
New Summary:  "parsing invalid frameset values for cols and rows"

Is this an invalid bug?  (I assume that because it was just assigned, that it
truly is a problem.. but I would have personally marked it invalid due to wrong
code/syntax)

Comment 3

[harishd]

Parser does not handle attribute values. It just consumes values and hands it
over to layout. Reassigning to rod.

Comment 4

[rods (gone)]

over to evaughan, the new owneer of framesets

Comment 5

[Håkan Waara]

Attachment: Patch -u v1

This fix will make us default to "100%" if we iterate over a value we can't
match in any other way.

This makes the testcase work fine.   Reviews?

Comment 6

[Bernd]

sorry but I don't like the patch, it gives illegal values a maximum weight and
will create new problems with cols= 200, no  or any other strange syntax. I
think we should more follow the logic of NS_CONTENT_ATTR_NOT_THERE and omitt the
cols(rows) where we can't parse the value

Comment 7

[Kevin McCluskey (gone)]

Bulk re-assigning all of Eric's HTMLFrame bugs to John.

Comment 8

[Emmanuel Bourg]

*** Bug 220033 has been marked as a duplicate of this bug. ***

Comment 9

[Vedran Miletic]

retargeting

Comment 10

[Boris Zbarsky [:bzbarsky]]

Actually, I think hwaara's patch may have been the right thing.  Consider the
following <frameset> decls, which should all be equivalent (the first three per
spec, the last one by common sense):

<frameset cols="*" rows="50%, 50%">

<frameset rows="50%, 50%">

<frameset cols="100%" rows="50%, 50%">

<frameset cols="garbage" rows="50%, 50%">

All that said, the testcase (about to be attached) worksforme, so marking the
bug accordingly.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase