Closed
Bug 996545
Opened 10 years ago
Closed 10 years ago
Disable the conversation inputbox when the ui-conv is closed
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
920 bytes,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
Currently only reported to the error console (this._conv undefined).
Assignee | ||
Comment 1•10 years ago
|
||
I'm unsure about the wording of the string, but this does the job. Displaying a system message won't work for this as the conversation and browser are destroyed. Since this is irreversible, disabling the inputbox seems likely to cause less frustration than writing a system message when the user attempts to send anyway.
Attachment #8408183 -
Flags: review?(florian)
Assignee | ||
Comment 2•10 years ago
|
||
We decided against showing a string on IRC.
Attachment #8408183 -
Attachment is obsolete: true
Attachment #8408183 -
Flags: review?(florian)
Attachment #8408218 -
Flags: review?(florian)
Updated•10 years ago
|
Attachment #8408218 -
Flags: review?(florian) → review+
Assignee | ||
Updated•10 years ago
|
Summary: Warn the user if no uiConv exists when trying to send a message → Disable the conversation inputbox when the ui-conv is closed
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/3c403cc6faf4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•