Closed Bug 996549 Opened 7 years ago Closed 7 years ago

Wifi Hotspot settings SSID network name should NOT accept more than 32 chars

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S6 (25apr)
blocking-b2g 1.4+
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: vasanth, Assigned: khu)

References

()

Details

(Whiteboard: [caf priority: p2][good first bug][mentor=arthurcc][mentor-lang=zh][lang=js][CR 647258])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
jj.evelyn
: review+
Details | Review
STR:

1. Got Settings -> Internet Sharing -> Hotspot settings
2. Now in SSID field, enter name more than 32 characters,
3. Press OK and Turn on Hotspot.
4. It will Turn off immediately.

Expected: Since 32 characters is the max size of ssid,
after 32 characters it should not allow to keyin any more characters
Does this happen on 1.3?
Keywords: qawanted
The issue of being able to enter in more than 32 characters DOES reproduce on Buri 1.3

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140415053300
Gaia: 11d027ec28d8e8f09c76b35661222499e124abc8
Gecko: 18b4ce6cf540
Version: 28.0
Firmware Version: v1.2-device.cfg
Keywords: qawanted
QA Contact: jharvey
Component: Wifi → Gaia::Settings
Hi Tim,

Could you find the right person to solve it?
Flags: needinfo?(timdream)
This is a good first bug I think.
Flags: needinfo?(timdream) → needinfo?(arthur.chen)
Whiteboard: [CR 647258] → [good first bug][mentor=arthurcc][mentor-lang=zh][lang=js][CR 647258]
Just adding that the fix is needed by 4/21. Kevin, please help move this along.
blocking-b2g: 1.4? → 1.4+
Flags: needinfo?(khu)
I think I can fix it.
Assignee: nobody → khu
Flags: needinfo?(khu)
Thanks, Kevin!
Flags: needinfo?(arthur.chen)
Attached file Gaia patch
Fixed by limiting the maximum number of characters to 32.
Attachment #8408012 - Flags: review?(ehung)
(In reply to Arthur Chen [:arthurcc] from comment #7)
> Thanks, Kevin!

No problem, Arthur. I saw you have 6 reviews in your queue, therefore, I asked Evelyn for review. Not sure if who(you or Evelyn) should be the best reviewer here? Thanks.
Comment on attachment 8408012 [details] [review]
Gaia patch

Kevin, you surprise me. Thanks for hands on the patch! :)
Attachment #8408012 - Flags: review?(ehung) → review+
merge into gaia master
https://github.com/mozilla-b2g/gaia/commit/966c130fed34052cc1d085fe96ae996c556eaafd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Sorry for the late request. Is it also possible to make sure this limit is set for Wifi Hotspot passphrase (8-63) chars?
Whiteboard: [good first bug][mentor=arthurcc][mentor-lang=zh][lang=js][CR 647258] → [caf priority: p2][good first bug][mentor=arthurcc][mentor-lang=zh][lang=js][CR 647258]
Flags: in-moztrap?(bzumwalt)
Found case https://moztrap.mozilla.org/manage/case/3548/

Needs updated STR to fit this bug
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
New step added to cover the 32 max character count for SSID network name has been added to this test case:

https://moztrap.mozilla.org/manage/case/3548/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(bzumwalt)
Flags: in-moztrap+
You need to log in before you can comment on or make changes to this bug.