996683 - Intermittent failing test, Find My Device lock > Lock the screen through the test app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

This has started failing quite often on travis, so we need to investigate this. Consider adding a waitFor() which pools for the expected text value.


Find My Device lock > Lock the screen through the test app:

AssertionError: "" == "This phone is lost."

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/findmydevice/test/marionette/findmydevice_test.js:44:12)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:372:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:448:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:297:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:307:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:245:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:213:5)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Kevin Grandon :kgrandon]

Disabled here: https://github.com/mozilla-b2g/gaia/commit/602430e5e3315bc1a55106545e19b7e8f4b32851

Comment 2

[Kevin Grandon :kgrandon]

Hi Guilherme - adding a needinfo? on you so you are aware. If you have some time please take a look. Thanks!

Comment 3

[Guilherme Gonçalves [:ggp]]

Attachment: use waitFor to poll the message text

Hi Kevin, thanks for the notice. I'm attaching a pull request with my attempt at implementing your waitFor() suggestion. I'll flag this r? once I have some confidence that this is working.

Comment 4

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8406992 [details] [review]
use waitFor to poll the message text

I've been running the integration tests on the Travis instance for my Gaia fork all afternoon (7 times so far) with no failures with this patch.

Marking this r? as it seems to be working, but please let me know if there are additional tests I should be running.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8406992 [details] [review]
use waitFor to poll the message text

I think 7 travis passes is enough for now, and we can revisit it later if needed. Thank you very much for the quick turnaround on this.

Comment 6

[Kevin Grandon :kgrandon]

Landed fix: https://github.com/mozilla-b2g/gaia/commit/28372f53d7768575a756864c8668942075043dc3

Comment 7

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.