Closed Bug 996690 Opened 10 years ago Closed 10 years ago

Enhance tag management given implementation of autotags

Categories

(Thunderbird :: Preferences, enhancement)

Product:
Thunderbird
Component:
Preferences
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr3132+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 32.0
Tracking Flags:
Tracking Status
thunderbird_esr31 32+ fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(2 files, 2 obsolete files)

tags.patch
1.46 KB, patch
mkmelin
: review+
standard8
: approval-comm-esr31+
Details | Diff | Splinter Review
tagssuite.patch
1.51 KB, patch
iannbugzilla
: review+
Details | Diff | Splinter Review 
Bug 946279 introduced automatic tagging of feed messages.  These tags are categorized with ~AUTOTAG in an nsIMsgTag.ordinal attribute.

1. Messagelist contextmenu and Messge->Tag should exclude autotags from the list unless they are tagged to the current message.
2. The Display->Tags panel should have an autotag column with checkbox indicating autotag.  Unchecking autotag promotes it to the group of regular user defined tags.
3. The FilterEditor, Search, and Saved Search properties dialog Tags menulist should exclude autotags.
Attached patch tags.patch (obsolete) — — Splinter Review 
parts 1 and 3.
Assignee: nobody → alta88
Attachment #8407017 - Flags: review?(mkmelin+mozilla)
Attached patch tagssuite.patch (obsolete) — — Splinter Review 
parts 1 and 3, suite.
Attachment #8407019 - Flags: review?(philip.chee)
Comment on attachment 8407017 [details] [diff] [review]
tags.patch

Review of attachment 8407017 [details] [diff] [review]:
-----------------------------------------------------------------

I think part 1 is fine, but part 3 makes are areas where autotags could be very useful so I don't think we should do that globally. We could hide them if it's not a feed account though I guess.
Attachment #8407017 - Flags: review?(mkmelin+mozilla) → review-
Attached patch tags.patch — — Splinter Review 

        Attachment #8407017 -
        Attachment is obsolete: true

        Attachment #8411812 -
        Flags: review?(mkmelin+mozilla)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        tagssuite.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8407019 -
        Attachment is obsolete: true

        Attachment #8407019 -
        Flags: review?(philip.chee)

        Attachment #8411813 -
        Flags: review?(philip.chee)

    
    

    
  
Comment on attachment 8411812 [details] [diff] [review]
tags.patch

Review of attachment 8411812 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin

        Attachment #8411812 -
        Flags: review?(mkmelin+mozilla) → review+

    
    

    
  
for Tb, suite can port whenever.
Keywords: checkin-needed

    
  

        Attachment #8411813 -
        Flags: review?(philip.chee) → review+

    
    

    
  
https://hg.mozilla.org/comm-central/rev/88f351932b28
https://hg.mozilla.org/comm-central/rev/b0fe02f08f35
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0

    
    

    
  
Comment on attachment 8411812 [details] [diff] [review]
tags.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

        Attachment #8411812 -
        Flags: approval-comm-aurora?

    
    

    
  
this should follow bug 946279.

    
    

    
  
Comment on attachment 8411812 [details] [diff] [review]
tags.patch

I'll accept this, but I generally prefer to have a fuller description of the implications and why it needs to be backported.

        Attachment #8411812 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

    
    

    
  
Comment on attachment 8411812 [details] [diff] [review]
tags.patch

Somehow this got missed, and looks like it should be part of esr.

        Attachment #8411812 -
        Flags: approval-comm-aurora+ → approval-comm-esr31?

        Attachment #8411812 -
        Flags: approval-comm-esr31? → approval-comm-esr31+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: