996700 - Wrong differences between versions

Status: RESOLVED WONTFIX

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Tim [:pollti]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140414004003

Steps to reproduce:

I went to https://support.mozilla.org/de/kb/Ist-Malware-an-meinem-Firefox-Problem-Schuld/compare?locale=de&to=60942&from=60707 (german, but problem also exists sometimes between english versions).


Actual results:

The difference doesn't show the whole text of lines 1 & 8. (It only shows the difference instead of the whole line as normal).


Expected results:

It should show the whole text of the line. (e.g. like in line 19)

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

I'm not sure I totally understand your issue but I've cc'ed Joni.

Comment 2

[Tim [:pollti]]

Sorry, my english isn't that good:
The problem is, that line 1 has more text in the full source code, than it's shown in the difference.

I'm offline for one week now, so I can't answer for a while.

Comment 3

[Joni Chan]

Thanks for looping me in, Andrew.

Tim, if I understand correctly, the entire first paragraph is cut off, and only the last phrase "und sie wieder loswerden." shows up when you compare two versions?

I don't know why that happened, but Ricky or Kadir can probably give us some insight.

Comment 4

[Tim [:pollti]]

Yes Joni, that's what I mean :D Thanks you!

Comment 5

[Tim [:pollti]]

Attachment: difference.png

Comment 6

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Ricky or Kadir? Any ideas why?

Comment 8

[Alice Wyman]

(In reply to Joni Savage from comment #3)
> I don't know why that happened, but Ricky or Kadir can probably give us some
> insight.

(In reply to Andrew Truong [:feer56] from comment #6)
> Ricky or Kadir? Any ideas why?

Kadir ?

Comment 9

[Kadir Topal [:atopal]]

It seems to me like the diff tool is trying to be clever here and cuts irrelevant things off, using commas and full stops as markers of relevance. 

Is this actually an issue? I mean does this make comparison harder? To me it seems like it might make it easier, actually.

Comment 10

[Tim [:pollti]]

Sometimes the missing context makes it hard to understand the changes.
IIRC the diff tool also cuts off some changes if there are some in the first part of such a longer sentence (but I'm not completely sure).

Comment 12

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

doesn't sound like it's hard, but needs dev folks which we currently don't have and it's not urgent so p3

Comment 13

[Seburo]

Closed as per https://blog.mozilla.org/sumo/2019/06/07/sumo-platform-roadmap/