clean up preferences xul alignment issues

VERIFIED FIXED in mozilla0.9.7

Status

--
minor
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: doronr, Assigned: doronr)

Tracking

({polish})

Trunk
mozilla0.9.7
x86
All
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

17 years ago
1. Navigator-> helper apps -> new type
2. mail -> msg display (missing smiley and another issue)
3. mail -> msg composition

These have some alignment issues, patch coming
cool, doron!

btw, is this issue independent of theme? just a-wonderin'...
(Assignee)

Comment 2

17 years ago
Created attachment 49589 [details] [diff] [review]
diff -u patch
(Assignee)

Comment 3

17 years ago
sairuh: no, this is not theme specific

cc: ben as this is preferences.

Also, I took liberty to upgrade the xul on these files (<text class="label"> ->
<label>, for="" -> control="")

The patch fixes some minor alignment issues in:

appearance -> colors
  make the colorpicker's labels align with the collorpickers

navigator -> helper apps -> new type  the labels now align with the textbox's
mail and news -> message display
  character coding: to alling with the drop down
mail and news -> mssg composition
  "then," aligned with the dropdown, same for "character coding"

Not sure if there is another bug about coverting the other files to use the new
xul changes, but that is another issue.

Any comments?
Status: NEW → ASSIGNED
Keywords: patch, polish, ui

Comment 4

17 years ago
Comment on attachment 49589 [details] [diff] [review]
diff -u patch

>-      <hbox style="margin-top: 5px">
>-        <text class="label" value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" for="backgroundmenu"/>
>+      <hbox style="margin-top: 5px" align="center">
>+        <label value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" control="backgroundmenu"/>

Ugh. Is that hard-coding really visually needed?  (Fix all occurences please)

>         <spring flex="1"/>

While you are at it, make <spring/> -> <spacer/> ... Same here, fix all usages.


After those changes. r=hwaara
Attachment #49589 - Flags: needs-work+
(Assignee)

Comment 5

17 years ago
the hard coding is there to put some vertical space between the colorpickers,
and therefore needed (unless ben says it can go).  Will change spring foo
(Assignee)

Comment 6

17 years ago
Created attachment 50248 [details] [diff] [review]
new patch against trunk
(Assignee)

Updated

17 years ago
Attachment #49589 - Attachment is obsolete: true
(Assignee)

Comment 7

17 years ago
new patch, based on trunk (where jag made a spring->spacer mass change). Not
touching the hardcoded part, unless ben goodger agrees (which I doubt, it looks
better with imho). I don't think it warrants to add a style rule for that.
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 8

17 years ago
Created attachment 50284 [details] [diff] [review]
newer patch
(Assignee)

Comment 9

17 years ago
sorry for the spam, the newer patch catchs a missed for="" and fixes the
"message display" tab issues that appeared yesterday.
(Assignee)

Comment 10

17 years ago
push
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.6 → mozilla0.9.7
(Assignee)

Comment 11

17 years ago
this got fixed by someone else it seems while this bitrotted
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
okidoke, rs vrfy.

newer and/or seperate issues here can be filed separately, then.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.