1. Navigator-> helper apps -> new type 2. mail -> msg display (missing smiley and another issue) 3. mail -> msg composition These have some alignment issues, patch coming
cool, doron! btw, is this issue independent of theme? just a-wonderin'...
sairuh: no, this is not theme specific cc: ben as this is preferences. Also, I took liberty to upgrade the xul on these files (<text class="label"> -> <label>, for="" -> control="") The patch fixes some minor alignment issues in: appearance -> colors make the colorpicker's labels align with the collorpickers navigator -> helper apps -> new type the labels now align with the textbox's mail and news -> message display character coding: to alling with the drop down mail and news -> mssg composition "then," aligned with the dropdown, same for "character coding" Not sure if there is another bug about coverting the other files to use the new xul changes, but that is another issue. Any comments?
Status: NEW → ASSIGNED
Keywords: patch, polish, ui
Comment on attachment 49589 [details] [diff] [review] diff -u patch >- <hbox style="margin-top: 5px"> >- <text class="label" value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" for="backgroundmenu"/> >+ <hbox style="margin-top: 5px" align="center"> >+ <label value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" control="backgroundmenu"/> Ugh. Is that hard-coding really visually needed? (Fix all occurences please) > <spring flex="1"/> While you are at it, make <spring/> -> <spacer/> ... Same here, fix all usages. After those changes. r=hwaara
Attachment #49589 - Flags: needs-work+
the hard coding is there to put some vertical space between the colorpickers, and therefore needed (unless ben says it can go). Will change spring foo
Attachment #49589 - Attachment is obsolete: true
new patch, based on trunk (where jag made a spring->spacer mass change). Not touching the hardcoded part, unless ben goodger agrees (which I doubt, it looks better with imho). I don't think it warrants to add a style rule for that.
Target Milestone: --- → mozilla0.9.5
sorry for the spam, the newer patch catchs a missed for="" and fixes the "message display" tab issues that appeared yesterday.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.7
this got fixed by someone else it seems while this bitrotted
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
okidoke, rs vrfy. newer and/or seperate issues here can be filed separately, then.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.