99678 - clean up preferences xul alignment issues

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Doron Rosenberg (IBM)]

1. Navigator-> helper apps -> new type
2. mail -> msg display (missing smiley and another issue)
3. mail -> msg composition

These have some alignment issues, patch coming

Comment 1

[sairuh (rarely reading bugmail)]

cool, doron!

btw, is this issue independent of theme? just a-wonderin'...

Comment 2

[Doron Rosenberg (IBM)]

Attachment: diff -u patch

Comment 3

[Doron Rosenberg (IBM)]

sairuh: no, this is not theme specific

cc: ben as this is preferences.

Also, I took liberty to upgrade the xul on these files (<text class="label"> ->
<label>, for="" -> control="")

The patch fixes some minor alignment issues in:

appearance -> colors
  make the colorpicker's labels align with the collorpickers

navigator -> helper apps -> new type  the labels now align with the textbox's
mail and news -> message display
  character coding: to alling with the drop down
mail and news -> mssg composition
  "then," aligned with the dropdown, same for "character coding"

Not sure if there is another bug about coverting the other files to use the new
xul changes, but that is another issue.

Any comments?

Comment 4

[Håkan Waara]

Comment on attachment 49589 [details] [diff] [review]
diff -u patch

>-      <hbox style="margin-top: 5px">
>-        <text class="label" value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" for="backgroundmenu"/>
>+      <hbox style="margin-top: 5px" align="center">
>+        <label value="&backgroundColor.label;" accesskey="&backgroundColor.accesskey;" control="backgroundmenu"/>

Ugh. Is that hard-coding really visually needed?  (Fix all occurences please)

>         <spring flex="1"/>

While you are at it, make <spring/> -> <spacer/> ... Same here, fix all usages.


After those changes. r=hwaara

Comment 5

[Doron Rosenberg (IBM)]

the hard coding is there to put some vertical space between the colorpickers,
and therefore needed (unless ben says it can go).  Will change spring foo

Comment 6

[Doron Rosenberg (IBM)]

Attachment: new patch against trunk

Comment 7

[Doron Rosenberg (IBM)]

new patch, based on trunk (where jag made a spring->spacer mass change). Not
touching the hardcoded part, unless ben goodger agrees (which I doubt, it looks
better with imho). I don't think it warrants to add a style rule for that.

Comment 8

[Doron Rosenberg (IBM)]

Attachment: newer patch

Comment 9

[Doron Rosenberg (IBM)]

sorry for the spam, the newer patch catchs a missed for="" and fixes the
"message display" tab issues that appeared yesterday.

Comment 10

[Doron Rosenberg (IBM)]

push

Comment 11

[Doron Rosenberg (IBM)]

this got fixed by someone else it seems while this bitrotted

Comment 12

[sairuh (rarely reading bugmail)]

okidoke, rs vrfy.

newer and/or seperate issues here can be filed separately, then.