996911 - Make nsIDOMXUL*Element not inherit from nsIDOMXULElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

JS consumers don't care, and C++ consumers can QI if needed.  This will let us make nsIDOMXULElement noscript.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make nsIDOMXUL*Element not inherit from nsIDOMXULElement, so we can make the latter noscript.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8407202 [details] [diff] [review]
Make nsIDOMXUL*Element not inherit from nsIDOMXULElement, so we can make the latter noscript.


>+      nsCOMPtr<nsIDOMXULElement> xulElement(do_QueryInterface(controlElement));
> 
>       nsCOMPtr<nsIDOMElement> oldKidElem = do_QueryInterface(oldKid);
>-      if (controlElement && oldKidElem) {
>+      if (controlElement && xulElement && oldKidElem) {
You don't need controlElement in the |if|

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(this needs a try run)

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30c536b1ee34 with the extra check removed and a try run run.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30c536b1ee34