Closed Bug 996911 Opened 5 years ago Closed 5 years ago

Make nsIDOMXUL*Element not inherit from nsIDOMXULElement

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

JS consumers don't care, and C++ consumers can QI if needed.  This will let us make nsIDOMXULElement noscript.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8407202 [details] [diff] [review]
Make nsIDOMXUL*Element not inherit from nsIDOMXULElement, so we can make the latter noscript.


>+      nsCOMPtr<nsIDOMXULElement> xulElement(do_QueryInterface(controlElement));
> 
>       nsCOMPtr<nsIDOMElement> oldKidElem = do_QueryInterface(oldKid);
>-      if (controlElement && oldKidElem) {
>+      if (controlElement && xulElement && oldKidElem) {
You don't need controlElement in the |if|
Attachment #8407202 - Flags: review?(bugs) → review+
(this needs a try run)
https://hg.mozilla.org/integration/mozilla-inbound/rev/30c536b1ee34 with the extra check removed and a try run run.
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/30c536b1ee34
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.