Closed Bug 997095 Opened 11 years ago Closed 11 years ago

[Tarako] Disable slog on user build

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 1.3T+
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: kk1fff, Assigned: ying.xu)

Details

(Whiteboard: [POVB])

slog impact much on performance, for example, it takes about 50% CPU usage during comms app start-up. And it is on even in user build. It should be turned off on performance related test.
Flags: needinfo?(james.zhang)
triage: [POVB], this should be disabled @ user build. To James. thanks
Assignee: nobody → james.zhang
blocking-b2g: 1.3T? → 1.3T+
Whiteboard: [POVB]
Component: General → Gaia::Build
We merge build patch for build uboot image, but we should revert some Thomas's change. - ADDITIONAL_DEFAULT_PROPERTIES += ro.secure=1 + ADDITIONAL_DEFAULT_PROPERTIES += ro.secure=0 - ADDITIONAL_DEFAULT_PROPERTIES += ro.debuggable=0 + ADDITIONAL_DEFAULT_PROPERTIES += ro.debuggable=1 slog depend on ro.debuggable, if we set ro.debuggable=0, we can disable it. And we can reopen it by spreadtrum engineer mode. commit 764d305457219f60e254f610c7c7e70c1c2d65a3 Author: ying.xu <ying.xu@spreadtrum.com> Date: Mon Apr 14 12:20:54 2014 +0800 Bug#0 merge patches of build [self test ] build pass
Assignee: james.zhang → ying.xu
Flags: needinfo?(james.zhang) → needinfo?(ttsai)
Flags: needinfo?(dliang)
Thomas, help.
short term, you can workaround with |adb stop slog|
(In reply to Fabrice Desré [:fabrice] from comment #4) > short term, you can workaround with |adb stop slog| Do we need adb on user build?
(In reply to James Zhang from comment #5) > (In reply to Fabrice Desré [:fabrice] from comment #4) > > short term, you can workaround with |adb stop slog| > > Do we need adb on user build? Yes, we need adb in both user and userdebug build.
Flags: needinfo?(dliang)
Fixed on my side. If anybody want to reopen, please let Danny check with my hudson build first. commit 5f4c045991e44c20e6480bc4e9dd41dd1f5f9eaa Author: Yiwen Liu <yiwen.liu@spreadtrum.com> Date: Thu Apr 17 18:48:38 2014 +0800 Bug #302670 In user release,default:adb on,slog off [bug number ] [root cause ] [changes ] [side effects] [self test ] user ok [reviewers ] Change-Id: I435af8bd4d41df1bd8641220fb901feaeaa7f27a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(ttsai)
You need to log in before you can comment on or make changes to this bug.