Closed
Bug 997166
Opened 10 years ago
Closed 10 years ago
Don't start NetworkSeer for app urls?
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: smaug, Assigned: u408661)
References
Details
Attachments
(1 file)
3.33 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
Currently we start NetworkSeer service and related thread when loading initial app url. I don't see reasons for that.
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Comment 1•10 years ago
|
||
In fact, do we ever need to start NetworkSeer in case of app: urls?
(In reply to Olli Pettay [:smaug] from comment #1) > In fact, do we ever need to start NetworkSeer in case of app: urls? No need to start the seer at all for app: uris. Probably the easiest way is to call IsNullOrHttp in the helper functions before getting a reference to the seer. Doing it the right way (not doing any work in Init if mEnabled = false after reading the pref) is significantly more invasive and prone to breakage.
Here's the straightforward version. We can probably do the bigger/more correct fix as part of the backend rewrite. Passes try: https://tbpl.mozilla.org/?tree=Try&rev=2566b7de380f
Assignee: nobody → hurley
Attachment #8408339 -
Flags: review?(mcmanus)
Updated•10 years ago
|
Attachment #8408339 -
Flags: review?(mcmanus) → review+
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c0d6c8a242e5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Reporter | ||
Comment 6•10 years ago
|
||
Since Seer creates a new thread, should we perhaps get this to b2g branches ?
blocking-b2g: --- → 1.3T?
Comment 7•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #6) > Since Seer creates a new thread, should we perhaps get this to b2g branches ? I am going to clear this nomination as its unclear if you are requesting it to be a blocker for the Tarako branch or a general request to have this in on any branch ? If its the latter and 1.5 would be an appropriate firefox version to get this change into. That is based on Gecko 32.
Updated•10 years ago
|
blocking-b2g: 1.3T? → ---
Would this help with startup performance for on device apps?
Reporter | ||
Comment 9•10 years ago
|
||
As far as I see yes. I found this bug when profiling b2g app startup.
You need to log in
before you can comment on or make changes to this bug.
Description
•