997166 - Don't start NetworkSeer for app urls?

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Currently we start NetworkSeer service and related thread when loading initial app url.
I don't see reasons for that.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

In fact, do we ever need to start NetworkSeer in case of app: urls?

Comment 2

[u408661]

(In reply to Olli Pettay [:smaug] from comment #1)
> In fact, do we ever need to start NetworkSeer in case of app: urls?

No need to start the seer at all for app: uris. Probably the easiest way is to call IsNullOrHttp in the helper functions before getting a reference to the seer. Doing it the right way (not doing any work in Init if mEnabled = false after reading the pref) is significantly more invasive and prone to breakage.

Comment 3

[u408661]

Attachment: patch

Here's the straightforward version. We can probably do the bigger/more correct fix as part of the backend rewrite.

Passes try: https://tbpl.mozilla.org/?tree=Try&rev=2566b7de380f

Comment 4

[u408661]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c0d6c8a242e5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0d6c8a242e5

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Since Seer creates a new thread, should we perhaps get this to b2g branches ?

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Olli Pettay [:smaug] from comment #6)
> Since Seer creates a new thread, should we perhaps get this to b2g branches ?

I am going to clear this nomination as its unclear if you are requesting it to be a blocker for the Tarako branch or a general request to have this in on any branch ?

If its the latter and 1.5 would be an appropriate firefox version to get this change into. That is based on Gecko 32.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Would this help with startup performance for on device apps?

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

As far as I see yes. I found this bug when profiling b2g app startup.