Closed Bug 997179 Opened 6 years ago Closed 6 years ago
Bing search is not present in the default search engines
Environment: Device: Google Nexus 7 (Android 4.4.2); Build: Nightly 31.0a1 (2014-04-16); Steps to reproduce: 1. Go to settings -> Customize -> Search; 2. Check if Bing search is available. Expected result: Bing search is available. Actual result: Bing search is not present in the default search engines.
Usually with bugs like these we'll want to make sure we identify and track them as highly visible regressions. https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5405d6f4e3c6&tochange=8883360b1edb
In an affected build, I do see the bing.xml is packaged (e.g, in en-US) $ ls -al omni.ja/assets/chrome/en-US/locale/en-US/browser/searchplugins/ -rw-rw-r-- 1 AaronMT staff 2860 1 Jan 2010 bing.xml
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#1946 means the Bing plugin will get discarded. Yay. Taking.
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Pretty straightforward. Added a comment for clarity.
Attachment #8407552 - Flags: review?(mark.finkle)
Attachment #8407552 - Flags: review?(mark.finkle) → review+
Landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/58b82c1143fb
Flipping these since I just saw uplift in bug 984530.
Comment on attachment 8407552 [details] [diff] [review] bingFix [Approval Request Comment] Bug caused by (feature/regressing bug #): 984530 User impact if declined: no bing search Testing completed (on m-c, etc.): verified fixed on inbound builds Risk to taking this patch (and alternatives if risky): very low String or IDL/UUID changes made by this patch: none Also will be requesting for bug 997402. This stuff needs more automated testing (tracking under Bug 997485) but I'll work with QA to verify manually ASAP
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Verified as fixed in build 31.0a1 (2014-04-17); Device: Google Nexus 7 (Android 4.4.2).
Verified as fixed in build 30.0a2 (2014-04-18); Device: Lenovo Yoga Tab 10 (Android 4.2.2). Will mark the bug as verified after retesting the bug on beta 10.
Verified as fixed in build 29 beta 10. Device: Google Nexus 7 (Android 4.4.2).
Seems like mobile could use a variant of the desktop browser_google|bing_behavior.js tests?
Yep, tracking test coverage under bug 997485, focusing on desktop first.
You need to log in before you can comment on or make changes to this bug.