Closed Bug 99725 Opened 23 years ago Closed 23 years ago

Sidebar: What's Related , moves maximised window out of pos.

Categories

(SeaMonkey :: Sidebar, defect, P3)

Product:
SeaMonkey
Component:
Sidebar
Platform:
x86
Windows 2000
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: anders_pedersen, Assigned: samir_bugzilla)

References

Details

(Whiteboard: [ready to checkin])

Attachments

(1 file)

Patch to remove resizing code that was in Alexa's tab that has not applciable to us.
939 bytes, patch
matt
: review+
bugzilla
: superreview+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.4+) Gecko/20010914
BuildID:    20001091403

Opening the sidebar and selecting "what's related" makes a maximised mozilla
move out of position. Instead of centered covering the whole screen, the window
moves abit out of position, keeping the same dimensions of the window.

Reproducible: Always
Steps to Reproduce:
1. View -> Sidebar -> What's Related


Actual Results:  A maximised Mozilla moves out of position.

Expected Results:  The window should stay maximised, filling the screen completely.
Sujay, 
Can you reproduce this?  All platforms?
Yes, can be reproduced. Recently installed Build ID 2001091703, same problem 
with this one. Don't know how the situation is on other platforms.
Can't reproduce this using 2001091703 on my Win2K system.  Awaiting QA
investigation for reproducible testcase.

Anders,
Are there any additional conditions I should consider when trying to reproduce
this?  Here is what I did:

(1) Open the sidebar in a maximized browser window.
(2) The "Search" tab pops up as the default for me in this case.
(3) Switch to the "What's Related" tab by clicking on it.

My maximized browser window does not appear to shift.  Thanks.
No, you're doing the right thing.
Priority: -- → P3
Target Milestone: --- → Future
I can reproduce this on win98, trunk 2001091508. The window (top left corner
position) is restored, but it stays the size of a maximised window.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Beginning to sound like Win9x/WinME users are seeing this.  Can't reproduce this
on my WinNT4.0 and Win2K systems.  Awaiting QA investigation.
I'll take a look at this today.
just tried in 9/26 branch build.

I cannot reproduce this problem.

Asa, can you try in a mozilla build?

Tracy can you try this on the trunk in tomorrow's(9/27) smoketesting?
thanks.
I can confirm this with 092603 mozilla win32 trunk build on win2K. Sujay, if you
need to see it feel free to wander by my cube.

Steps to reproduce:
1. maximize window
2. view sidebar
3. select bookmarks or some tab other than what's related
4. select what's related tab

Results:
The window is unmaximized 

Expected results:
The window does not change state
I thought I saw this on someone else's linux machine but after extensive testing
on my linux trunk build 092608 I cannot reproduce. This appears to be win32 only
and TRUNK ONLY. 
Sujay,  I am not able to reproduce this.  clicking what's related tab with 
window maximized does not move the window.  I'm on win98.
Tracy, this is TRUNK only...maybe you have branch ..
sujay, I knew you were going to say that.

I could not reproduce this on windows commercial build 2001-09-27-05-trunk.

I should have said it in the first place.
Definately happening on Win2k here, build 2001092503 (which is a TRUNK build).
*** Bug 103078 has been marked as a duplicate of this bug. ***
*** Bug 104536 has been marked as a duplicate of this bug. ***
also mentioned in bug 104554
*** Bug 104759 has been marked as a duplicate of this bug. ***
*** Bug 104837 has been marked as a duplicate of this bug. ***
*** Bug 106264 has been marked as a duplicate of this bug. ***
*** Bug 104554 has been marked as a duplicate of this bug. ***
I'm having the same problem with v0.9.5 on Win2K.

May I suggest slightly changing the description for this bug?  I submitted a
duplicate, because this report doesn't contain much information and so I missed
it in my searches (and apparently I'm not the only one).  My description was as
follows:

"Choosing "What's related" on the sidebar causes a maximized window to restore
down, or become non-maximized.  This is especially annoying because even if
re-maximized, the browser just restores down again immediately when it's restarted."
OK, this is pretty annoying and I can reproduce it consistently (I may have not
followed the steps right first time around).  Have working patch.
Status: NEW → ASSIGNED
OS: Windows ME → Windows 2000
Target Milestone: Future → mozilla0.9.6
matt, please r.
blake, please sr.
Keywords: patch, review
Comment on attachment 54712 [details] [diff] [review]
Patch to remove resizing code that was in Alexa's tab that has not applciable to us.

sr=blake
Attachment #54712 - Flags: superreview+
Comment on attachment 54712 [details] [diff] [review]
Patch to remove resizing code that was in Alexa's tab that has not applciable to us.

I think this was in there from a really old workaround but my memory is failing me.
Attachment #54712 - Flags: review+
Comment on attachment 54712 [details] [diff] [review]
Patch to remove resizing code that was in Alexa's tab that has not applciable to us.

I think this was in there from a really old workaround but my memory is failing me.
Keywords: review
Whiteboard: [ready to checkin]
Ah, now I know why I couldn't reproduce this: the netscape what's related panel
code is different than the mozilla incarnation (mozilla's is from Alexa I
believe).  So this was a mozilla-only bug.
*** Bug 106948 has been marked as a duplicate of this bug. ***
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 108814 has been marked as a duplicate of this bug. ***
using buildID: 2001110703 on WinME

Works for me :)
verified.
Status: RESOLVED → VERIFIED
*** Bug 109430 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: