997265 - Consolidate Provider objects and provider constants.

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[Stuart Colville [:muffinresearch]]

Currently we have constants for providers e.g: https://github.com/mozilla/zamboni/blob/master/apps/constants/payments.py#L121

And we also have shiny new provider objects defined in mkt.developers.providers. https://github.com/mozilla/zamboni/blob/master/mkt/developers/providers.py#L237

This bug is to remove the constants in favour of using the objects so there's a single source of truth for providers.

Comment 1

[Andy McKay]

Having a constant that refers to a provider is pretty useful, eg:

https://github.com/mozilla/zamboni/blob/master/mkt/developers/models.py#L61-L62

Comment 2

[Andy McKay]

And those constants are the same in solitude and webpay...

Comment 3

[Stuart Colville [:muffinresearch]]

(In reply to Andy McKay [:andym] from comment #2)
> And those constants are the same in solitude and webpay...

So maybe the answer is to keep the constants but have them reference the provider objects?

Comment 4

[Stuart Colville [:muffinresearch]]

So seems like there's a good use-case in keeping the constants - perhaps we can instead think about folding the objects into the constants file to be consistent with how we have defined regions?

Comment 5

[Andy McKay]

Someone could move it to marketplace-constants.