Remove uses of halign="left"

VERIFIED FIXED in Future

Status

Core Graveyard
Security: UI
P2
normal
VERIFIED FIXED
17 years ago
a year ago

People

(Reporter: Stephen Walker, Assigned: Rangan Sen)

Tracking

1.0 Branch
Future
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
halign="left" is unnecessary on <hbox>'s, it should be removed from the 3 psm 
pref files that currently use it.
(Reporter)

Comment 1

17 years ago
Created attachment 49425 [details] [diff] [review]
patch
(Reporter)

Updated

17 years ago
Keywords: patch, review

Comment 2

17 years ago
->rangansen
Rangan.  Follow up with reviewers, and check in onto the trunk.
Assignee: ssaux → rangansen
Priority: -- → P2
Target Milestone: --- → Future
(Assignee)

Comment 3

17 years ago
This patch seems to work fine on NT - apparently, having the 'halign=left' staff
is really redundant. But, can removing this cause any impact on other platforms?
I could not find 'halign' on any of the available xul documentations, though it
seems that the implementations actually supports it.
Otherwise, r=rangansen
(Reporter)

Comment 4

17 years ago
I don't think removing this will cause any issues on other platforms, because I 
think <hbox>'s default align value is left. cc'ing hewitt for input.

Updated

17 years ago
QA Contact: bsharma → junruh

Comment 5

17 years ago
There is no platform-specific behavior to worry about here.

Comment 6

17 years ago
sr=hewitt
(Assignee)

Comment 7

17 years ago
Patch checked in ...
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Verified on trunk per rangen's comment.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.