997310 - mozregression no longer works for thunderbird

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

From cadeyrn on github:

Hi,

mozregression does not work for Thunderbird anymore.

mozregression  --good=2013-12-17 --bad=2013-12-19 --app=thunderbird

results in:

2013-12-18
Could not find build from 2013-12-18
Last good build: 2013-12-17
First bad build: 2013-12-19
Pushlog:
None/pushloghtml?startdate=2013-12-17&enddate=2013-12-19

Could not find build from 2013-12-19
Could not find build from 2013-12-20
Could not find build from 2013-12-21
Could not find build from 2013-12-22
Could not find build from 2013-12-23
…

Another note: mozregression should not look for builds in the future… ;-)

Comment 1

[Julien Pagès (:parkouss)]

I looked at it, and it is still a valid bug.

I think that there are two cause for the bug:

1. the thunderbird nightly url is actually wrong in my opinion. We point to something like
   http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/12/ instead of
   http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/12/.
   
   This could be resolved by adding to ThunderbirdNightly [1] a class attribute like
   "build_base_repo_name = 'thunderbird'".

2. In the while loop in bisect_nightlies [2], we are doing an infinite loop if builds installs
   never succeed even if we have reached the bad date. This may happen if the builds folders like
   http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/12/2013-12-18-03-02-06-comm-central/
   are incomplete (builds infos and binaries are missing).
   
   We can fix this by checking if bad date is reached and if we cannot install any build,
   and in this case exit the program and inform the user of what's happenning.
   
   This way we will also remove the "None" pushlog printed in comment #0.

William, what do you think ?

[1] https://github.com/mozilla/mozregression/blob/master/mozregression/runnightly.py#L188

[2] https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L186

Comment 2

[William Lachance (:wlach)]

Makes sense to me. :)

Comment 3

[Julien Pagès (:parkouss)]

Allright then, I'm on it.

Comment 4

[Julien Pagès (:parkouss)]

Attachment: mozregression no longer works for thunderbird

Comment 5

[Julien Pagès (:parkouss)]

I will look at bug 1025892 to see how it is related.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8452169 [details] [review]
mozregression no longer works for thunderbird

This looks reasonable, though I would like to see the date range logic moved to a separate patch, can you make that modification?

Comment 7

[Julien Pagès (:parkouss)]

Sure! You're right that it is another bug and so must appear as another patch. Thank you. :)
It's rebased.

Comment 8

[Sam Garrett]

(In reply to Julien Pagès from comment #7)
> Sure! You're right that it is another bug and so must appear as another
> patch. Thank you. :)
> It's rebased.

Hi Julien,

I was testing this out and here is the output I get:

$ mozregression  --good=2013-12-17 --bad=2013-12-19 --app=thunderbird
BI regex: thunderbird.*mac.*\.txt$
Running nightly for 2013-12-18
Tried to get builds from http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/12/ that match 'thunderbird.*mac.*\.dmg$' but didn't find any.
Could not find build from 2013-12-18
Running nightly for 2013-12-19
Downloading build from: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2013/12/2013-12-19-03-02-02-comm-central/thunderbird-29.0a1.en-US.mac.dmg
===== Downloaded 100% =====
Installing nightly
Starting nightly (revision: c1bb1f98c4c5)
Last good build: 2013-12-17
First bad build: 2013-12-19
Pushlog:
None/pushloghtml?startdate=2013-12-17&enddate=2013-12-19

"None/pushloghtml..." is still being printed out. It looks like "get_app_info()" for Thunderbird isn't returning the value used in https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L128.

Comment 9

[Julien Pagès (:parkouss)]

Hi William,

You're right that "None/pushloghtml..." is still being printed out.

I looked at it but it doe not seems to me that it is related to https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L128 as it is for bisecting inbounds.

I think that's because the self.found_repo variable is set too late here: https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L197. I moved that code just after the nightly build was well started (https://github.com/mozilla/mozregression/pull/110/files#diff-fa686b102516e50aa7df8250dd9a10a6R187) and now the pushlog line is well printed.

It is rebased - again -, tell me if the solution is incorrect.

Comment 10

[William Lachance (:wlach)]

Your pull request looked good, so I merged it. I think we still have more work to do to make mozregression work well with thunderbird, though we can do that in followup bugs, if people are interested. I'll mark this as resolved for now.