997317 - BrowserElementChild shouldn't use Services.scriptloader.loadSubScript

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Olli Pettay [:smaug][[e-mail]]]

Services.scriptloader.loadSubScript doesn't seem to get the same script caching
what frame scripts get, and that leads to parsing/compiling the scripts when
doing window.open().

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

this is btw up to 20% of the window.open call in case of "Sheet app 4".
If loadSubScript wasn't used, some of the 20% could be removed, I think, but some of the time
would be just spent elsewhere.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

But looks like just compiling is 15% or so, and we could get rid of that, if I read the profile
and code correctly.

Comment 3

[[:fabrice] Fabrice Desré]

Olly, what can we use instead of loadSubscript? mm.loadFrameScript?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Yes, I'd use that, since when opening a new window/tab, we have the script compiled and cached
and all we need to do is execute it. Profiler showed compilation of those loadSubscript things
taking time.

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

You mean open window in the same child process right?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Yes, same (child) process window.open.

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.