997338 - NFC: Added null-check in fromUTF8() in shared/js/nfc_utils.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Kamil Leszczuk [:kamituel]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.152 Safari/537.36



Actual results:

In gaia/shared/js/nfc_utils.js, comments for fromUTF8(str) and toUTF8(a) are mixed (reversed).

Comment 1

[Ken Chang[:kenkai]]

Please this into backlog.

Comment 2

[Kamil Leszczuk [:kamituel]]

Attachment: Fixes comments.

Comment 3

[Ken Chang[:kenkai]]

Comment on attachment 8411241 [details] [review]
Fixes comments.

Alive, may you please help to have a review?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8411241 [details] [review]
Fixes comments.

Thanks, but I prefer to use jsdoc format like
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_window.js#L797
Could you do it?

Comment 5

[Kamil Leszczuk [:kamituel]]

Attachment: In addition to comment fixes, add null-check in fromUTF8() as well.

In addition to comment fixes, add null-check in fromUTF8() as well.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8412177 [details] [review]
In addition to comment fixes, add null-check in fromUTF8() as well.

r+ if you assert the nullStr

Comment 7

[Kamil Leszczuk [:kamituel]]

Added assertion - I guess it's ready to be merged. Thanks!

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Hi there, please amend your commit message to this format
"Bug XXXXXXX - WHAT_YOU_DO_TO_FIX_THIS_BUG"
You could see examples from git log.

Comment 9

[Kamil Leszczuk [:kamituel]]

Done.

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I have fixed the comments in Bug 997075.
Perhaps Kami could help to add more checks comments in this bug.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:allstars.chh] from comment #10)
> I have fixed the comments in Bug 997075.
> Perhaps Kami could help to add more checks comments in this bug.

Sorry,
I thought Kami was trying to fix the typo which I fixed in Bug 997075, and I saw he added some JSDOC comments.
but I realize now he's adding the check in the other function, which is different from what I did.

Updating the subject of this bug for this.

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://github.com/mozilla-b2g/gaia/commit/1ba9199d69f4621b78556ab0ce716c641728dffa