Closed Bug 997432 Opened 6 years ago Closed 6 years ago

log failures when MozParams don't include a condition attribute

Categories

(Firefox :: Search, defect, minor)

x86_64
Windows 8
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: mconnor, Assigned: mconnor)

Details

Attachments

(1 file)

This has always been the behaviour, but we should have logging instead of just silently failing.
Attachment #8407835 - Flags: review?(gavin.sharp)
Comment on attachment 8407835 [details] [diff] [review]
logInvalidMozParam

Did you hit this in practice?

It's probably better to use this._location rather than this._name for the error message, since it's possible (though probably uncommon) for the name to only be parsed after the bogus MozParam.
Attachment #8407835 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dfe9f74ddd2

addressed gavin's review comment.  I did hit this (bug 997402, sigh)
https://hg.mozilla.org/mozilla-central/rev/9dfe9f74ddd2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.