997489 - Lots of jsreftest warnings spam from '[JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information ...]'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Ed Morley [:emorley]]

eg:
Android 4.0 Panda mozilla-inbound opt test jsreftest-1 on 2014-04-16 15:20:16 PDT for push 0d37b75f8cd3
https://tbpl.mozilla.org/php/getParsedLog.php?id=37959927&tree=Mozilla-Inbound

15:51:49     INFO -  --------- beginning of /dev/log/main
15:51:49     INFO -  04-16 15:48:49.875 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-03.js" line: 15}]
...
15:51:49     INFO -  04-16 15:48:51.664 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-04.js" line: 15}]
...
15:51:49     INFO -  04-16 15:48:52.117 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-05.js" line: 15}]
...
15:51:49     INFO -  04-16 15:48:52.937 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-334807-06.js" line: 15}]
...
15:51:49     INFO -  04-16 15:48:53.343 E/GeckoConsole( 2118): [JavaScript Warning: "An unbalanced tree was written using document.write() causing data from the network to be reparsed. For more information https://developer.mozilla.org/en/Optimizing_Your_Pages_for_Speculative_Parsing" {file: "http://10.12.131.19:30379/jsreftest/tests/jsreftest.html?test=js1_5/Regress/regress-336100.js" line: 15}]

Henri, I'm guessing one of the document.write()s in https://mxr.mozilla.org/mozilla-central/source/js/src/tests/browser.js is messed up? Would you mind taking a look? :-)

Comment 1

[Henri Sivonen (:hsivonen)]

https://mxr.mozilla.org/mozilla-central/source/js/src/tests/browser.js#108

108   var s = "<tt>"+ string ;
109   s += "<b>" ;
110   s += ( passed ) ? "<font color=#009900> &nbsp;" + PASSED
111     : "<font color=#aa0000>&nbsp;" +  FAILED + expect + "</tt>";
112 
113   DocumentWrite( s + "</font></b></tt><br>" );
114   return passed;
115 }

When |passed| is false, there is a stray </tt> tag.

Comment 2

[Ed Morley [:emorley]]

Ah indeed, thank you :-)

Comment 3

[Ed Morley [:emorley]]

Attachment: Fix stray </tt> tag causing JS warning spam during jsreftests

Fixes the console JS warning spam during jsreftests in comment 0.
(Also... yuck @ the style inconsistency in this file)

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 8408175 [details] [diff] [review]
Fix stray </tt> tag causing JS warning spam during jsreftests

Review of attachment 8408175 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure why me for this, but it's obvious and quick enough.  :-)

Comment 5

[Ed Morley [:emorley]]

Thank you :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e733167dc8ac

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #4)
> Not sure why me for this, but it's obvious and quick enough.  :-)

hg log

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e733167dc8ac