997500 - [Tarako] Tapping any element spawns a flood of gralloc errors: gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Tony Chung [:tchung]]

Attachment: logcat

Tapping any elements on the screen (calendar, home button, etc..) spawns a flood of gralloc_unregister_buffer errors.   i'm concerned that these gralloc buffers never get freed up and will OOM the device quickly.

/cc mwu for further comments.

logcat snippet
************
04-16 16:40:04.660: E/[Gralloc-ERROR](84): int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*):274 Trying to unregister buffer 0x47a0bb50 from process 84 that was not created in current process: 84
04-16 16:40:04.660: E/[Gralloc-ERROR](84): int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*):274 Trying to unregister buffer 0x47a0bab0 from process 84 that was not created in current process: 84
04-16 16:40:04.660: E/[Gralloc-ERROR](84): int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*):274 Trying to unregister buffer 0x47804a60 from process 84 that was not created in current process: 84
04-16 16:40:04.660: E/[Gralloc-ERROR](84): int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*):274 Trying to unregister buffer 0x46332d80 from process 84 that was not created in current process: 84

Repro:
1) install 1.3T nightly user build on Tarako
Gaia      718a06816327fcb6a18095f677cfff4b86adc292
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/9ef12c19ddc9
BuildID   20140416004007
Version   28.1
ro.build.version.incremental=215
2) tap any element on the screen (ie. contacts app, dialer app, browser, etc..)
3) watch logcat and verify gralloc_unregister_buffer errors

Expected:
- no gralloc_unregister_buffer errors

Comment 1

[Michael Wu [:mwu]]

This comes from sprd/common/libs/gralloc/gralloc_module.cpp in gralloc_unregister_buffer. It suggests that we're not unregistering gralloc buffers, which seems bad. The check that says |else if (hnd->pid != getpid())| seems to be inverted according to the comment on that line.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Sotaro had explained the message here : https://bugzilla.mozilla.org/show_bug.cgi?id=988731#c9

Comment 3

[James Zhang (Spreadtrum)]

ying, please check this log with our graphic team and remove it.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Not sure but this might be related as well?  https://bugzilla.mozilla.org/show_bug.cgi?id=996912#c13

Comment 5

[ying.xu]

(In reply to Michael Wu [:mwu] from comment #1)
> This comes from sprd/common/libs/gralloc/gralloc_module.cpp in
> gralloc_unregister_buffer. It suggests that we're not unregistering gralloc
> buffers, which seems bad. The check that says |else if (hnd->pid !=
> getpid())| seems to be inverted according to the comment on that line.

Please refer the register interface here.
There would no graphic buffer that allocated and registered in the same process.
registering the buffer handle would return directly.

This make unregister interface be reasonable.

static int gralloc_register_buffer(gralloc_module_t const* module, buffer_handle_t handle)
{
	// if this handle was created in this process, then we keep it as is.
	private_handle_t* hnd = (private_handle_t*)handle;
	if (hnd->pid == getpid())   //here
	{
		AERR("Unable to register handle 0x%x coming from different process: %d", (unsigned int)hnd, hnd->pid );
		return 0;
	}

Comment 6

[ying.xu]

commit 4d37004047ef9f6fbde01213a7f8336845aac859
Author: ying.xu <[e-mail]>
Date:   Fri Apr 18 10:23:22 2014 +0800

    Bug#302801 remove error logs in graphic module
    
    [self test   ] boot to homescreen
    
    Change-Id: Iee58ab1f16e5497fb4776ebfafd8350e0f181686

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: give 1.3T already fixed by partner. 1.3T+