Closed Bug 997598 Opened 10 years ago Closed 10 years ago

don't strip leading white space from mochitest output lines when stack fixer is in use

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
When a stack fixer is being used to process mochitest output, it strips leading and trailing white space from all lines.  Stripping leading white space messes debugging output from functions like DumpFrameTree that layout hackers use a lot.  So let's not strip the leading white space.
Attachment #8408008 - Flags: review?(wlachance)
Comment on attachment 8408008 [details] [diff] [review]
patch

Review of attachment 8408008 [details] [diff] [review]:
-----------------------------------------------------------------

makes sense to me, I think this was an oversight when I last touched the code a few months ago
Attachment #8408008 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/280c066afbf1
Assignee: nobody → cam
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.