997625 - Sync panel: Checkbox for syncing passwords enabled (not disabled) while sync credentials need reauth

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Nightly on Windows 8.1

Regression from bug 970167.

When the user has successfully set up sync locally but syncing fails on the server side (e.g. password changed on the server but not locally), the checkboxes what kind of data should be sync become disabled except the password checkbox.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2

Try run with 2 unrelated WebGL oranges: https://tbpl.mozilla.org/?tree=Try&showall=1&rev=3ff966028851

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8408178 [details] [diff] [review]
patch, v2

Review of attachment 8408178 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/e73e1719edcb

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tracking for 30 and 31.

Do you want to have in 29?

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Yes, I think it would be really great to have this in 29. It's a very visible glitch and a very trivial fix.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

OK. Can you fill the uplift request?

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8408178 [details] [diff] [review]
patch, v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 970167
Testing completed (on m-c, etc.): Manual smoke testing.
Risk to taking this patch (and alternatives if risky): Low risk.
String or IDL/UUID changes made by this patch: None.

User impact if declined: 
Without this patch the checkbox for the passwords sync engine will always be enabled. When signed in with an unverified email address all checkboxes are disabled except the passwords engine, which looks really off and is very visible.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0add478cf3b4
https://hg.mozilla.org/releases/mozilla-beta/rev/0add478cf3b4

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/21f26a2f6877

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e73e1719edcb

Comment 11

[moses]

Verified fixed in 29, 30, and 31 on Windows 8.1 x64

Comment 12

[Bogdan Maris, Desktop QA]

I can also confirm that this is verified.