Closed
Bug 997656
Opened 10 years ago
Closed 10 years ago
Tracelogger: Log when baseline is compiling
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
3.29 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Adding loggers for baseline compiler, since it might be good to know how much time this takes ;)
Assignee: nobody → hv1989
Attachment #8408146 -
Flags: review?(kvijayan)
Comment 2•10 years ago
|
||
Comment on attachment 8408146 [details] [diff] [review] bug997656-tl-baselinecompile Review of attachment 8408146 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. ::: js/src/vm/TraceLogging.cpp @@ +69,5 @@ > > // The text that will get logged for eagerly created logged text. > // When adding/removing something here, you must update the enum > // Tracelogger::TextId in TraceLogging.h too. > const char* const text[] = { This array should have static (file-only) scoping, and preferrably all-caps naming. ::: js/src/vm/TraceLogging.h @@ +209,5 @@ > // Predefined IDs for common operations. These IDs can be used > // without using TraceLogCreateTextId, because there are already created. > // When changing the enum here, you must update the array containing the > // actual logged text in TraceLogging.cpp. > enum TextId { This TextId enum seems to be getting long-enough to deserve the generator-macro treatment, e.g.: #define TEXT_ID_LIST(_) _(Bailout) \ ... Then it can be used by all of |enum TextId|, |const char *const text|, and the initialization code |enableTextIds[...] = true|.
Attachment #8408146 -
Flags: review?(kvijayan) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Kannan Vijayan [:djvj] from comment #2) > This TextId enum seems to be getting long-enough to deserve the > generator-macro treatment, e.g.: > > #define TEXT_ID_LIST(_) > _(Bailout) \ > ... Yes, indeed ! https://hg.mozilla.org/integration/mozilla-inbound/rev/a90a994dee5f
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a90a994dee5f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•