Closed
Bug 997688
Opened 10 years ago
Closed 10 years ago
nsSocketTransport should track SocketTransportService via smart ptr
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
12.06 KB,
patch
|
sworkman
:
review+
|
Details | Diff | Splinter Review |
stop using RELEASE/ADDREF on gPtr.. just hold a nsRefPtr<> local(gPtr). Convert any inscope references to gPtr to local.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=cdcc8849005d
Assignee | ||
Updated•10 years ago
|
Attachment #8408176 -
Flags: review?(sworkman)
Comment 3•10 years ago
|
||
Comment on attachment 8408176 [details] [diff] [review] nsSocketTransport should track SocketTransportService via smart ptr Review of attachment 8408176 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/base/src/nsSocketTransport2.h @@ +331,5 @@ > bool mFDconnected; // mFD is available to consumer when TRUE. > > + // a delete protector reference to gSocketTransportService held for lifetime > + // of 'this'. Sometimes used interchangably with gSocketTransportService due > + // to scoping. nit: _A_ delete protector ...
Attachment #8408176 -
Flags: review?(sworkman) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/caf503c905c0
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/caf503c905c0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•