Closed
Bug 997695
Opened 11 years ago
Closed 11 years ago
[stage] PayPal frame does not appear while trying to Make a Contribution
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
2014-06
People
(Reporter: AndreiH, Assigned: magopian)
References
()
Details
(Whiteboard: [fromAutomation])
# STR:
1. Go to https://addons.allizom.org
2. Log in.
3. Go to an addon details page and click on "Contribute"
4. Click on "Make a Contribution" button
# Expected results:
PayPal frame should appear.
# Actual results:
PayPal frame does not appear.
Screencast:
http://screencast.com/t/8H0EvL1UM
Reporter | ||
Updated•11 years ago
|
Whiteboard: [fromAutomation]
Reporter | ||
Comment 1•11 years ago
|
||
This is now happening on Dev also :(
Comment 2•11 years ago
|
||
Stacktrace (most recent call last):
File "django/core/handlers/base.py", line 114, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "addons/decorators.py", line 32, in wrapper
return f(request, addon, *args, **kw)
File "amo/decorators.py", line 51, in wrapper
return f(request, *args, **kw)
File "addons/views.py", line 532, in contribute
contrib.save()
File "django/db/models/base.py", line 545, in save
force_update=force_update, update_fields=update_fields)
File "django/db/models/base.py", line 573, in save_base
updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
File "django/db/models/base.py", line 654, in _save_table
result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
File "django/db/models/base.py", line 687, in _do_insert
using=using, raw=raw)
File "django/db/models/manager.py", line 232, in _insert
return insert_query(self.model, objs, fields, **kwargs)
File "django/db/models/query.py", line 1511, in insert_query
return query.get_compiler(using=using).execute_sql(return_id)
File "django/db/models/sql/compiler.py", line 899, in execute_sql
cursor.execute(sql, params)
File "django/db/backends/util.py", line 53, in execute
return self.cursor.execute(sql, params)
File "django/db/utils.py", line 99, in __exit__
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "django/db/backends/util.py", line 53, in execute
return self.cursor.execute(sql, params)
File "django/db/backends/mysql/base.py", line 124, in execute
return self.cursor.execute(query, args)
File "MySQLdb/cursors.py", line 205, in execute
self.errorhandler(self, exc, value)
File "MySQLdb/connections.py", line 36, in defaulterrorhandler
raise errorclass, errorvalue
http://sentry.dmz.phx1.mozilla.com/addons/addons-stage/group/18904/
Assignee | ||
Comment 3•11 years ago
|
||
I've spotted the issue thanks to [:mat]'s help
Assignee | ||
Comment 4•11 years ago
|
||
I've spotted the issue thanks to :mat : the "Contribution.type" field has been removed from the code (https://github.com/mozilla/olympia/commit/ad7b8e4f84c787c20c0c34d874f8e3aa0d047963#diff-5c77591fae9c3b2a440565c722df93f4L148), and the migration that was supposed to make this removal effective in the database was reverted (https://github.com/mozilla/olympia/commit/436b3dbe8807ccc29b89535b07fd2d3603a5ec8c).
This means there's still a "type" field in the database waiting for a value, that is never provided by the code.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mathieu
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
It should be fixed in https://github.com/mozilla/olympia/commit/de787b06fac29d99945887b85b7f1984be834dba (Appart from the sentry log, I have no clue if there's anything else causing issues, so it's a bit of a guess).
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 2014-04
Comment 7•11 years ago
|
||
This issue is still reproducible on Stage
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•11 years ago
|
||
Hello Victor, could you please try again?
The database migration wasn't properly executed it seems, and it should be now.
Comment 9•11 years ago
|
||
Issue is no longer reproducing in https://addons.allizom.org/ on FF29 (Win 7). http://screencast.com/t/9KdSgOwX
Updated•11 years ago
|
Target Milestone: 2014-04 → 2014-06
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Verified as fixed in FF29 (Win 7).
Closing bug.
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•