997734 - [l10n] Improve localizability of privacy center (Fx OS Privacy page)

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Francesco Lodolo [:flod]]

https://www.mozilla.org/it/privacy/firefox-os/

One string is currently not localizable ("Back to Mozilla Privacy Policy"), since the string is not wrapped.

There's also another problem: see the second "Ulteriori informazioni"? Is displayed on a new line because of this style.

.main-column article .highlight [role="tab"] a {
    display: inline-block;
    margin: 0px 0.5em;
    font-size: 14px;
    font-family: "Open Sans","Droid Arabic Naskh","Mplus Fulah",sans-serif;
    white-space: nowrap;
}

Do we really need these links to act like buttons?

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

For now only wrapping the text in a l10n call.

Kohei, what about the CSS?

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/337b9ebe308aae14bfb2e4494f84641f0dfe2037
Bug 997734 - [l10n] Improve localizability of privacy center (Fx OS Privacy page)

https://github.com/mozilla/bedrock/commit/cdb9a8b358d20efb664d0edd884cf3cb0f9f809e
Merge pull request #1893 from flodolo/l10n_privacy

Bug 997734 - [l10n] Improve localizability of privacy center (Fx OS Privacy page)

Comment 3

[Kohei]

Attachment: followup pull request

(In reply to Francesco Lodolo [:flod] from comment #0)
> One string is currently not localizable ("Back to Mozilla Privacy Policy"),
> since the string is not wrapped.

Sorry about the l10n wrap. It should be localizable.

> Do we really need these links to act like buttons?

No, it doesn't have to. Sent a PR to fix it.

Comment 4

[Mike Alexis [:malexis]]

Looks like this is on production. Resolving.

Comment 5

[Kohei]

https://github.com/mozilla/bedrock/pull/1894 is still open.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ba17d2e818ca520624f5231679120c6ade6669d2
Fix Bug 997734 - [l10n] Improve localizability of privacy center (Fx OS Privacy page)

https://github.com/mozilla/bedrock/commit/61d7d61c34de9bb3e2b0786081975e46786cdf97
Merge pull request #1894 from kyoshino/bug-997734-privacy-center-l12y

Fix Bug 997734 - [l10n] Improve localizability of privacy center (Fx OS Privacy page)