997787 - Page resizes when resetting usage from Settings menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Zac C (:zac)]

STR:
1. Load Usage app
2. Tap settings cog
3. Tap 'Reset'
4. Choose 'reset wifi and mobile'

Observe the page layout as the values are reset. The "x B" and date/time string are removed, causing all elements on the page to shift up. then when they are replaced with "0.00 B" and the present date the elements shift down again.
It would look better if the values were cleared without causing the elements to shift location.

Hamachi
Gaia      dadf0e60a6421f5b57ee9fc536c6617212805c19
Gecko     https://hg.mozilla.org/mozilla-central/rev/c55dfb01a027
BuildID   20140417040206
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Marina Rodríguez [:mai]]

NI to UX to define what must be the correct behaviour

Comment 2

[Marina Rodríguez [:mai]]

NI to UX to define what should be the correct behaviour

Comment 3

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Salva,
would you mind reviewing the patch?
Regards

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8458629 [details] [review]
patch v1.0

Nice catch, thank you.

Comment 5

[Marina Rodríguez [:mai]]

Master: db2ed8d5ff52734e4c1b6611f24d323de99adab8

Comment 6

[Marina Rodríguez [:mai]]

Comment on attachment 8458629 [details] [review]
patch v1.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

This patch prevents an unnecessary reload of the settings, due to the incorrect use of the action menu component of the building block.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: poor ux when the user resetting wifi or mobile data traffic
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/248a996d8179034c14eb6ed3c54265d0bbeee04b

Comment 8

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.0 & v2.1
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034308
FW-Date         Mon Dec  1 03:43:18 EST 2014
Bootloader      L1TC00011880

Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034405
FW-Date         Mon Dec  1 03:44:15 EST 2014
Bootloader      L1TC00011880