Closed
Bug 997799
Opened 10 years ago
Closed 10 years ago
[meta] Make search app accessible.
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
Rocketbar uses search app to display search results. Their a11y needs to improve.
|
Assignee | |
Comment 1•10 years ago
|
||
I wanted to get some feedback if the pull request is sensible, in your opinion.
Attachment #8410490 -
Flags: feedback?(eitan)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8410490 [details] [review] Github pull request. Commented in github.
Attachment #8410490 -
Flags: feedback?(eitan)
|
|
Assignee | |
Updated•10 years ago
|
No longer blocks: 994694
Component: Gaia → Gaia::Search
Summary: Make search results in search app accessible. → [meta] Make search app accessible.
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8410490 [details] [review] Github pull request. Updated the PR with some of Eitan's comments, some issues were also discussed in IRC (around http://krijnhoetmer.nl/irc-logs/accessibility/20140428#l-211)
Attachment #8410490 -
Flags: review?(kgrandon)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8410490 [details] [review] Github pull request. Looks pretty good to me. Just left one comment on github. It would be good to have tests to not regress this.
Attachment #8410490 -
Flags: review?(kgrandon) → review+
|
|
||
Comment 6•10 years ago
|
||
Thanks! I can merge it for you: https://github.com/mozilla-b2g/gaia/commit/7265e4df33ed0272e3faf683ab1f87acf48cee4d
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•