Closed
Bug 997817
Opened 12 years ago
Closed 12 years ago
make tags in kits load dynamically after kit is created, so as not to confuse users.
Categories
(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fuzzyfox, Assigned: fuzzyfox)
References
Details
Attachments
(1 file)
While the kits were being tested at the recent training in London I noticed there was a little confusion as to how to tag their kits. Some thought that as they'd already updated the tags section in the HTML that they were done, and then wondered why they were being prompted for more tags when publishing their kit.
My proposal is to either completely remove this section (which I'd rather not do as I see value in having it easy to see a kits tags) OR, my preferred method, which is to have this section populated by the kit using the make api.
Will build this out into something demoable/mergable for clarity.
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #8408455 -
Flags: review?(kate)
Comment 2•12 years ago
|
||
Comment on attachment 8408455 [details] [review]
https://github.com/mozilla/webmaker-kits/pull/10
Looks good, how do I test locally?
Attachment #8408455 -
Flags: review?(kate) → review-
| Assignee | ||
Comment 3•12 years ago
|
||
So I tested it out by copying the JS directly into a make (url for my test below) and checking the results. Not pretty I know but I couldn't think of a better way.
https://moz-wduyck.makes.org/thimble/LTY3NTM0ODQ4MA==/teaching-kit-template
| Assignee | ||
Updated•12 years ago
|
Attachment #8408455 -
Flags: review- → review?
| Assignee | ||
Updated•12 years ago
|
Attachment #8408455 -
Flags: review? → review?(kate)
Comment 4•12 years ago
|
||
Comment on attachment 8408455 [details] [review]
https://github.com/mozilla/webmaker-kits/pull/10
Ok works for me
Attachment #8408455 -
Flags: review?(kate) → review+
| Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•