Closed Bug 997825 Opened 10 years ago Closed 10 years ago

[rtl] Unicorn doesn't bounce

Categories

(Firefox :: Toolbars and Customization, defect)

30 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 31
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- verified

People

(Reporter: tomer, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P5])

Attachments

(2 files)

Attached video screencast
Steps to reproduce: (based on STR from bug 996610)
0. Run an RTL build of Firefox such as Arabic or Hebrew.
1. Enter customization mode.
2. Move all the items out of the panel menu.
3. Exit customization mode.
4. Open the panel menu and observe the bouncing unicorn.

Actual result:
Unicorn goes up and down and not bounce to the sides.
Whiteboard: [Australis:P5]
OS: Linux → All
Hardware: x86 → All
Sad broken unicorn.
Attachment #8408367 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8408367 [details] [diff] [review]
fix the broken unicorn,

Review of attachment 8408367 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

apparently it's been broken ever since the feature landed. makes me sad, i thought i had tested this with RTL.
Attachment #8408367 - Flags: review?(jaws) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=7385eb179c83
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7385eb179c83
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 31
Comment on attachment 8408367 [details] [diff] [review]
fix the broken unicorn,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug in initial implementation of bug 934075
User impact if declined: no horizontal movement of the unicorn on RTL
Testing completed (on m-c, etc.): locally and on m-c
Risk to taking this patch (and alternatives if risky): none expected 
String or IDL/UUID changes made by this patch: none
Attachment #8408367 - Flags: approval-mozilla-aurora?
Attachment #8408367 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
QA Whiteboard: [good first verify]
firefox31.0 -> working smoothly(fixed)
Thanks!
Status: RESOLVED → VERIFIED
QA Contact: cbaba20
QA Whiteboard: [good first verify] → [good first verify][bugday-20140611]
You need to log in before you can comment on or make changes to this bug.