Closed
Bug 997843
Opened 10 years ago
Closed 10 years ago
mozilla::pkix::der::Input::Expect should take a uint16_t as its length argument instead of a size_t
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: keeler, Assigned: keeler)
References
Details
Attachments
(1 file)
1.43 KB,
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
Bug 982774 factored out some length checking, resulting in a size_t being reinterpreted as a uint16_t. Since The length of an Input will never be longer than what can be expressed in a uint16_t, Expect could simply take a uint16_t (compare to Skip, which takes a uint16_t). Only OID uses Expect right now, and OIDs are short.
Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Attachment #8408372 -
Flags: review?(brian) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Great - thanks. https://hg.mozilla.org/integration/mozilla-inbound/rev/f854b5d978b5
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f854b5d978b5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•