997903 - Add query for user's likes

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Gavin Suntop [:gvn]]

We're going to need a method to be added to the API to support querying makes liked by a given user.

This is functionality that we're hoping to support on the new user profiles.

See: https://redpen.io/jhbfaw

Comment 1

[Chris DeCairos (:cade)]

how much of a blocker is this for you?

Comment 2

[Gavin Suntop [:gvn]]

It's a blocker for part of the new Profile, but it can wait a bit if other stuff is higher priority. FWIW I'm primarily working on Events this week...

Comment 3

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/211

Still need a makeapi-client update.

Comment 4

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/makeapi-client/pull/35

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 8412100 [details] [review]
https://github.com/mozilla/MakeAPI/pull/211

Gavin: does this do what you need?

GET /api/version/make/like/:username[?size=<number>]

Comment 6

[Gavin Suntop [:gvn]]

Comment on attachment 8412100 [details] [review]
https://github.com/mozilla/MakeAPI/pull/211

That looks good to me. I'm assuming that you get every Like if you don't specify a count?

Also, looks like this route will need to be added to the docs.

Comment 7

[Chris DeCairos (:cade)]

(In reply to Gavin Suntop [:gvn] from comment #6)
> Comment on attachment 8412100 [details] [review]
> https://github.com/mozilla/MakeAPI/pull/211
> 
> That looks good to me. I'm assuming that you get every Like if you don't
> specify a count?
no, you'll get a default of ten, max of 100 (not set in stone) I can also add pagination.

> Also, looks like this route will need to be added to the docs.
yes!

Comment 8

[Jon Buckley [:jbuck]]

Comment on attachment 8412117 [details] [review]
https://github.com/mozilla/makeapi-client/pull/35

This works, but lets change it from a separate search function to something that can be integrated into the main search function. Maybe as `likedBy`, `likedByUser`, or `likedByUsername`?

Comment 9

[Jon Buckley [:jbuck]]

Comment on attachment 8412100 [details] [review]
https://github.com/mozilla/MakeAPI/pull/211

Same as the other patch

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/52988669350f0eb4944871328b5c264c97cb0c2b
bug 997903
1. Add getUserLikes generator
2. Clean up search query generator with async waterfall

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/makeapi-client

https://github.com/mozilla/makeapi-client/commit/fb72787f89429d404d5936f1427461f01915fe0c
Bug 997903 - add searchUserLikes function for getting a user's liked makes