997934 - Makes view

Status: RESOLVED FIXED

(Webmaker Graveyard :: Profile, defect)

Description

[Gavin Suntop [:gvn]]

Implement the Makes view.

Comment 1

[Gavin Suntop [:gvn]]

Functionality is implemented, just needs to be styled.

Comp: https://www.dropbox.com/s/u94oou15luuxfu8/Profile2-v5.psd

Comment 2

[Aki Rose Braun [:akirose]]

Attachment: Syles makes view

currently WIP

Comment 3

[Gavin Suntop [:gvn]]

Comment on attachment 8421392 [details] [review]
Syles makes view

Some tweaks and comments/questions noted on GH. Generally looking great!

Once you're ready to merge we'll need you to squash your commits down.

Also, once you're ready to get design feedback take some screenshots at various widths (I usually do 320 and 960) and put them up on Redpen.io for design review (either Cassie or Kate can do this...).

Comment 4

[Aki Rose Braun [:akirose]]

I made all the changes you noted, and took bunches of screenshots and put 'em here -> https://www.dropbox.com/sh/oaxxt6qjls8bu06/AAC7AAJRqmw62d-qqSxIoveJa

I'll squash to one commit (which will close this bug) when I'm ready to merge. In the meantime should I `needinfo?`cassie/kate with the dropbox link? (I guess our redpen trial is over?)

Comment 5

[Gavin Suntop [:gvn]]

Ah, yeah I forgot it had expired. You can flag either Cassie or Kate with a "feedback" request (instead of "review"). That way they can + or - it like a regular code review.

Comment 6

[Cassie McDaniel [:cassiemc]]

You guys can use invision, basically the same as redpen but free. Give it a whirl? http://www.invisionapp.com/

Comment 7

[Aki Rose Braun [:akirose]]

Attachment: Screenshots at several viewports

(This does not include the buttons Newest | Most popular | Popcorn | Thimble | XRay Goggles, they are a separate bug)

Comment 8

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8422169 [details]
Screenshots at several viewports

Left some comments on invision.

Comment 9

[Aki Rose Braun [:akirose]]

Comment on attachment 8422169 [details]
Screenshots at several viewports

Updated screens with everything in scope addressed (I think)

Comment 10

[Aki Rose Braun [:akirose]]

Comment on attachment 8421392 [details] [review]
Syles makes view

I'm hoping for MVP we can look at this in scope and get it merged in before cassie is back? (is that reasonable? I don't know.)

Comment 11

[Gavin Suntop [:gvn]]

Yeah, lets try to move this forward. We can always refine design further post-MVP.

Comment 12

[Gavin Suntop [:gvn]]

Comment on attachment 8421392 [details] [review]
Syles makes view

Just a few notes on GH...

Comment 13

[Gavin Suntop [:gvn]]

Comment on attachment 8421392 [details] [review]
Syles makes view

Need to run `grunt lint`, but after that it's good to land!

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker-profile-2

https://github.com/mozilla/webmaker-profile-2/commit/0161146bc5b585aaaa2cca7ac36dc26880053910
Fixes Bug 997934 - Makes view

https://github.com/mozilla/webmaker-profile-2/commit/bf64cf5388d5c0ba1929d3d9c166726711163f0c
Merge pull request #6 from gesa/997934

Fix Bug 997934 - Makes view