Closed
Bug 997944
Opened 11 years ago
Closed 11 years ago
User metadata header
Categories
(Webmaker Graveyard :: Profile, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gvn, Assigned: gvn)
References
Details
(Whiteboard: [profile2][gvn][mvp])
Attachments
(2 files)
Implement the user metadata header.
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [profile2] → [profile2][pre-ah]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [profile2][pre-ah] → [profile2]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [profile2] → [profile2][gvn]
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
This is pretty much just MVP functionality. I'm gonna add more services to the regex later, but for now the major ones are covered...
Attachment #8421437 -
Flags: review?(aki)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8421437 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/7
Functionally, this works great for me in Chrome. As we discussed a few days ago, I'm having issues with my local Firefox install (with and without extensions running) but that seems to be an isolated problem.
As for meta-review (code style, angular conventions, etc) I don't think I'm familiar enough to be opinionated enough for an R-. Lgtm!
Attachment #8421437 -
Flags: review?(aki) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
This allows protocol-less URL adding, more closely matches the design and adds more service icons.
Attachment #8422866 -
Flags: review?(aki)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8422866 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/10
One note, optional change, LGTM :+1:
Attachment #8422866 -
Flags: review?(aki) → review+
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [profile2][gvn] → [profile2][gvn][mvp]
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•