997951 - [marketplace-tests-gaia] Clean up and bolster some tests which are failing intermittently

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

Attachment: Screenshot of the failure at [1]

The marketplace test suite on Firefox OS is mostly green, but still suffers from some intermittent failures. Some of these are actual valid failures (such as the error message seen during test_create_confirm_pin as seen at [1]), some are issues where the test is validly timing out (such as the Persona spinner seen during test_create_confirm_pin as seen at [2]). Some seem like timing issues that could be cleaned up so I have made a few tweaks to some tests/objects and have seen improved results locally. I will attach the PR for this to this bug.

[1] http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.hamachi.mozilla-b2g28_v1_3.v1.3.marketplace/346/HTML_Report/?
[2] http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.hamachi.mozilla-b2g28_v1_3.v1.3.marketplace/349/HTML_Report/?

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Screenshot of the failure at [2]

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/29

Comment 3

[[:AndreiH]]

Comment on attachment 8408481 [details] [review]
Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/29

My comments are in the PR.
The code looks good. I am ok with the changes, but there is one failure in one test that it is not related to the changes.
I just want that to be tested by someone else too.

Comment 4

[Florin Strugariu [:Bebe]]

Comment on attachment 8408481 [details] [review]
Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/29

Bob is working o a new version of this:

https://github.com/mozilla/marketplace-tests-gaia/pull/29#issuecomment-41185179

Comment 5

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/32

Comment 6

[[:AndreiH]]

Comment on attachment 8414509 [details] [review]
Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/32

Some comments in the PR, but this deserves an r+

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8414509 [details] [review]
Link to Github pull-request: https://github.com/mozilla/marketplace-tests-gaia/pull/32

Landed in https://github.com/mozilla/marketplace-tests-gaia/commit/de501ccf7736737047384399f7851a63cb2cb42f