997961 - Closing tag highlight needs to be higher contrast ( dark theme )

Status: RESOLVED DUPLICATE of bug 1246313

(DevTools :: Inspector, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: Firefox_closing_element_highlight_—_QuickCast__Make__Publish__Share__3_Minute_Screencasts.png

If you're using the dark theme there is a nice feature where ( for an expanded tag with children ) the line with the closing tag is highlighted for the selected opening tag. Problem is, the color chosen for the closing tag line is very dark and hard to see, it should be lighter in order to be generally more useful.

User screencast: http://quick.as/zxqtklg

Comment 1

[Brian Grinstead [:bgrins]]

It is pretty subtle on the light theme as well.  It is using theme-bg-darker for this:

https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/devtools/light-theme.css#24
https://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/devtools/dark-theme.css#24

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: theme-bg-darker-things.png

The only other place using theme-bg-darker is the alternating row styling on the computed view (see screenshot)

Comment 3

[Brian Grinstead [:bgrins]]

Of course this will be an easy fix if we can decide on an appropriate color.  Jeff, are you suggesting that the color is lighter than the background?  If we make it lighter than it is currently it will actually lower the contrast *until* it gets lighter than the original background.  We could also make it darker or add a bit of another color to make it stand out.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Sorry, what I'm suggesting is that there should be a great difference between the background and the color in question. I'm not a designer but it seems to me that with an already dark background you have more room in the colour spectrum getting lighter than getting darker.

I've also realized after some experimentation that my cheap monitor here at home makes things worse. For example, if I switch to the light theme the closing tag highlight color *is* visible on my Macbook Air's built-in LCD, but it is completely invisible on my monitor. 

I don't think the bad-monitor-settings factor invalidates this bug, in fact I think we need to be aware that not everyone has a decent monitor, and that higher-contrast improves usability.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Both the light and dark theme got refreshed IIRC. Helen, do you think this bug is still valid ?

Comment 6

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Nicolas Chevobbe from comment #5)
> Both the light and dark theme got refreshed IIRC. Helen, do you think this
> bug is still valid ?

I think this can safely be marked a duplicate of bug 1246313.