Closed Bug 997982 Opened 7 years ago Closed 7 years ago
Mark xpcom/glue/tests/gtest/ as FAIL
Bug 997306 leaves the directory xpcom/glue/tests/gtest/ warning-free on my system. Filing this bug on marking it as FAIL_ON_WARNINGS. Try run to see if there are any warnings on other platforms: https://tbpl.mozilla.org/?tree=Try&rev=9e63f7e32ba8 (I also verified that the patch in that ^ try run makes bug 997306 into a fatal build error on my system; i.e., the annotation does have an effect.)
("glue_gtest_fow.patch" is the relevant patch in the Try push above. The rest of the csets there are just things that recently landed on inbound, which I layered on top of.)
Here's the patch. I'll request review once the Try run is complete & any issues that it reveals are sorted out.
Comment on attachment 8408504 [details] [diff] [review] fix v1 Try run is looking good. Requesting review.
Attachment #8408504 - Flags: review?(nfroyd)
Attachment #8408504 - Flags: review?(nfroyd) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.