Closed
Bug 997982
Opened 10 years ago
Closed 10 years ago
Mark xpcom/glue/tests/gtest/ as FAIL_ON_WARNINGS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
610 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Bug 997306 leaves the directory xpcom/glue/tests/gtest/ warning-free on my system. Filing this bug on marking it as FAIL_ON_WARNINGS. Try run to see if there are any warnings on other platforms: https://tbpl.mozilla.org/?tree=Try&rev=9e63f7e32ba8 (I also verified that the patch in that ^ try run makes bug 997306 into a fatal build error on my system; i.e., the annotation does have an effect.)
Assignee | ||
Comment 1•10 years ago
|
||
("glue_gtest_fow.patch" is the relevant patch in the Try push above. The rest of the csets there are just things that recently landed on inbound, which I layered on top of.)
Assignee | ||
Comment 2•10 years ago
|
||
Here's the patch. I'll request review once the Try run is complete & any issues that it reveals are sorted out.
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(dholbert)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8408504 [details] [diff] [review] fix v1 Try run is looking good. Requesting review.
Attachment #8408504 -
Flags: review?(nfroyd)
Flags: needinfo?(dholbert)
Updated•10 years ago
|
Attachment #8408504 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b7262a6f29
Flags: in-testsuite-
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3b7262a6f29
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•