Mark xpcom/glue/tests/gtest/ as FAIL_ON_WARNINGS

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla31
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
Bug 997306 leaves the directory xpcom/glue/tests/gtest/ warning-free on my system.

Filing this bug on marking it as FAIL_ON_WARNINGS.

Try run to see if there are any warnings on other platforms:
 https://tbpl.mozilla.org/?tree=Try&rev=9e63f7e32ba8

(I also verified that the patch in that ^ try run makes bug 997306 into a fatal build error on my system; i.e., the annotation does have an effect.)
Assignee

Comment 1

5 years ago
("glue_gtest_fow.patch" is the relevant patch in the Try push above. The rest of the csets there are just things that recently landed on inbound, which I layered on top of.)
Assignee

Comment 2

5 years ago
Posted patch fix v1Splinter Review
Here's the patch. I'll request review once the Try run is complete & any issues that it reveals are sorted out.
Assignee

Updated

5 years ago
Flags: needinfo?(dholbert)
Assignee

Comment 3

5 years ago
Comment on attachment 8408504 [details] [diff] [review]
fix v1

Try run is looking good. Requesting review.
Attachment #8408504 - Flags: review?(nfroyd)
Flags: needinfo?(dholbert)
Attachment #8408504 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/f3b7262a6f29
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.