998015 - Disk cache uses timers from the wrong thread

Status: RESOLVED DUPLICATE of bug 913828

(Core :: Networking: Cache, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The assert in bug 998006 fires with this stack:

nsTimerImpl::AssertTargetOnCurrentThread() const
nsTimerImpl::Cancel()
nsDiskCacheMap::ResetCacheTimer(int)
nsDiskCacheMap::InvalidateCache()
nsDiskCacheMap::AddRecord(nsDiskCacheRecord*, nsDiskCacheRecord*)
nsDiskCacheDevice::BindEntry(nsCacheEntry*)
nsCacheService::EnsureEntryHasDevice(nsCacheEntry*)
nsCacheService::DeactivateEntry(nsCacheEntry*)
nsCacheService::CloseDescriptor(nsCacheEntryDescriptor*)
nsCacheEntryDescriptor::Close()
nsCacheEntryDescriptor::~nsCacheEntryDescriptor()
nsCacheEntryDescriptor::~nsCacheEntryDescriptor()
nsCacheEntryDescriptor::Release()
nsCOMPtr<nsICacheEntryInfo>::~nsCOMPtr()
mozilla::net::_OldCacheEntryWrapper::~_OldCacheEntryWrapper()
mozilla::net::_OldCacheEntryWrapper::Release()
nsCOMPtr<nsICacheEntry>::assign_assuming_AddRef(nsICacheEntry*)
nsCOMPtr<nsICacheEntry>::operator=(nsICacheEntry*)
mozilla::net::nsHttpChannel::CloseCacheEntry(bool)
mozilla::net::nsHttpChannel::ContinueProcessResponse(tag_nsresult)
mozilla::net::nsHttpChannel::OnRedirectVerifyCallback(tag_nsresult)
nsAsyncVerifyRedirectCallbackEvent::Run()

which makes sense: that's poking a timer from a thread other than the target thread of the timer, so a clear threadsafety violation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

And also the nsTimerImpl::Cancel from nsDiskCacheMap::Close, called when someone does mozilla::net::CacheStorageService::Clear.

Comment 2

[Honza Bambas (:mayhemer)]

Re comment 0: fixed with switching to the new cache.
Re comment 1: not sure this is fixed as well, but any old-cache-cleanup code we still call will soon be removed (at least as part of bug 913828).

Reverting to UNCONFIRMED.

Comment 3

[Florian Bender]

I'll just dupe this bug to Bug 913828 then.