998044 - [B2G][Tarako][Dialer]Speakerphone and Mute buttons do not work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: DialerButtonsNotFunctioning.txt

When in a phone call, the user can choose to put the call on speakerphone, or the can mute the audio. Neither of these buttons work in the latest tarako build. The buttons will briefly flash when tapped, but otherwise no changes occur.

Repro Steps:
1) Update Tarako to BuildID: 20140417004002
2) Launch Dialer.
3) Call a valid phone number.
4) During phone call, tap the speakerphone or mute buttons.

Actual:
Speakerphone and Mute buttons do not function.
 
Expected:
Speakerphone and Mute buttons function.

v1.3T Environmental Variables:
Device: Buri v1.3T 
BuildID: 20140417004002
Gaia: a8d2d399f2939f4845abaa0df57abab241a2c782
Gecko: d97dad54cb61
Version: 28.1
Firmware Version: sp6821


Repro frequency: 100%
See attached: logcat

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We're suppose to get a new PAC file soon.  Hopefully it doesn't exhibit in that.  Just in case noming.

Comment 2

[Wayne Chen [:xwaynec]]

From log, The switch command do the right routing control. Partner needs to take a look.


1. MO call starts
04-17 14:43:44.793: V/AudioPolicyManagerBase(88): setPhoneState() state 2

2. Switch to speaker
04-17 14:43:49.883: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2

3. Switch to earpiece
04-17 14:43:50.163: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1

4. Switch to speaker
04-17 14:43:53.243: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2

5. ......

Comment 3

[James Zhang (Spreadtrum)]

see bug http://bugzilla.spreadtrum.com/bugzilla/show_bug.cgi?id=302711
Please contact tony.li to discuss.

Comment 4

[Wayne Chen [:xwaynec]]

Sorry, comment 2 is wrong.

From log, AudioPolicy receive command to route for DEVICE_OUT_SPEAKER(2), and immediately(<1sec) receive another command to route for DEVICE_OUT_EARPIECE(1). Please Gaia owner have a check for 2 things:

1. Receive 2 times touch event? or
2. Send 2 times switch command?

Thanks

04-17 14:43:44.843: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1
04-17 14:43:49.883: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2
04-17 14:43:50.163: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1
04-17 14:43:53.243: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2
04-17 14:43:53.523: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1
04-17 14:43:58.663: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2
04-17 14:43:58.923: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1
04-17 14:44:01.553: V/AudioPolicyManagerBase(88): setOutputDevice() routing=2
04-17 14:44:01.863: V/AudioPolicyManagerBase(88): setOutputDevice() routing=1

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

also ni? Rik as there are quite a few bugs on Etienne already. see if Rik can offload a bit. thanks

Comment 7

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR against 1.3t

Comment 8

[Etienne Segonzac (:etienne)]

This was caused by a bad merge. This patch is tarako only.

Sorry.


(we were adding the click listener twice, which isn't cool for a toggle button :))

Comment 11

[Jason Smith [:jsmith]]

Not a smoketest blocker.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #11)
> Not a smoketest blocker.

Disregard - missed the fact that bug 997394 was already a smoketest blocker.

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8410280 [details] [review]
Gaia PR against 1.3t

Oopsie

Comment 14

[Keven Kuo [:kkuo]]

Hi! James,

Check in needed. Thanks

--
Keven

Comment 15

[James Zhang (Spreadtrum)]

(In reply to Keven Kuo [:kkuo] from comment #14)
> Hi! James,
> 
> Check in needed. Thanks
> 
> --
> Keven

Done.
https://github.com/mozilla-b2g/gaia/commit/f67c697dbed20b222dfcd81e41eb012dba0d62b9

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Closing this under the assumption that this was 1.3t-only. Please don't forget to mark the bugs when you push.

Comment 17

[Josh Schmitt [Joshs]]

Verified fixed on the latest 1.3T build.

The Mute and Speaker buttons are working properly. Pressing buttons in the number pad while in a call are working correctly and only showing 1 number as expected.

1.3 Environmental Variables:
Device: Tarako 1.3
BuildID: 20140424014003
Gaia: 706f474230432c8cb01e124aee2c055ec902aa1d
Gecko: 26ef3dded9ff
Version: 28.1
Firmware Version: sp6821

Comment 18

[Roland Kunkel [:RolandK]]

Verified comments #17 findings on latest v1.3T Tarako build. Updating tracking flag.