Closed Bug 998046 Opened 10 years ago Closed 10 years ago

WebGL PVRTC extension exposes the wrong enums

Categories

(Core :: Graphics: CanvasWebGL, defect)

30 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: tojiro, Assigned: jgilbert)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1941.0 Safari/537.36

Steps to reproduce:

On a device which supports the OpenGL ES extension IMG_texture_compression_pvrtc create an instance of the WEBGL_compressed_texture_pvrtc extension. It should have four enums attached to. (This can be quickly demonstrated by visiting http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_pvrtc/)



Actual results:

The extension object has the following for enums:

COMPRESSED_RGB_PVRTC_4BPPV1
COMPRESSED_RGB_PVRTC_2BPPV1
COMPRESSED_RGBA_PVRTC_4BPPV1
COMPRESSED_RGBA_PVRTC_2BPPV1


Expected results:

According to the extension spec (https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/webgl-compressed-texture-pvrtc.html) the four enums should be:

COMPRESSED_RGB_PVRTC_4BPPV1_IMG
COMPRESSED_RGB_PVRTC_2BPPV1_IMG
COMPRESSED_RGBA_PVRTC_4BPPV1_IMG
COMPRESSED_RGBA_PVRTC_2BPPV1_IMG

(Note the _IMG prefix)
Component: Untriaged → Canvas: WebGL
Product: Firefox → Core
Ugh, vendor suffixes.
Attached patch pvrtc-suffixesSplinter Review
Assignee: nobody → jgilbert
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8415627 - Flags: review?(dglastonbury)
Comment on attachment 8415627 [details] [diff] [review]
pvrtc-suffixes

Review of attachment 8415627 [details] [diff] [review]:
-----------------------------------------------------------------

Missed that when I went through all the valid texture formats from extensions.
Attachment #8415627 - Flags: review?(dglastonbury) → review+
Comment on attachment 8415627 [details] [diff] [review]
pvrtc-suffixes

r=me
Attachment #8415627 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/734b0e34e002
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.