Closed
Bug 998089
Opened 10 years ago
Closed 10 years ago
Packaged apps installed with wrong icon
Categories
(Firefox Graveyard :: Web Apps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file, 1 obsolete file)
1.09 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
Regression introduced by bug 898647, Beta is unaffected. The problem is that on Mac the zip file isn't in the installation directory but under the "Resources" dir.
Attachment #8408626 -
Flags: review?(tabraldes)
Comment 1•10 years ago
|
||
I don't really know anything about our Mac implementation of app installation. Is there someone else who could review this?
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8408626 [details] [diff] [review] Patch (In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #1) > I don't really know anything about our Mac implementation of app > installation. Is there someone else who could review this? Let's ask Felipe.
Attachment #8408626 -
Flags: review?(tabraldes) → review?(felipc)
Comment 3•10 years ago
|
||
Comment on attachment 8408626 [details] [diff] [review] Patch Review of attachment 8408626 [details] [diff] [review]: ----------------------------------------------------------------- Why pass this.zipFile as a parameter instead of making _getIcon directly use it?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to :Felipe Gomes from comment #3) > Comment on attachment 8408626 [details] [diff] [review] > Patch > > Review of attachment 8408626 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why pass this.zipFile as a parameter instead of making _getIcon directly use > it? That's right!
Assignee: nobody → mar.castelluccio
Attachment #8408626 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8408626 -
Flags: review?(felipc)
Attachment #8410642 -
Flags: review?(felipc)
Updated•10 years ago
|
Attachment #8410642 -
Flags: review?(felipc) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fcdca8a9cda1
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fcdca8a9cda1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Marco, do you need testing for this before Firefox 31 is released?
Flags: needinfo?(mar.castelluccio)
Assignee | ||
Comment 8•10 years ago
|
||
I've built a basic test (http://mxr.mozilla.org/mozilla-central/source/toolkit/webapps/tests/test_packaged_icons.xul), so I think this is covered.
Flags: needinfo?(mar.castelluccio)
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•