Packaged apps installed with wrong icon

RESOLVED FIXED in Firefox 31

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 31
All
macOS
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch (obsolete) — Splinter Review
Regression introduced by bug 898647, Beta is unaffected.

The problem is that on Mac the zip file isn't in the installation directory but under the "Resources" dir.
Attachment #8408626 - Flags: review?(tabraldes)
I don't really know anything about our Mac implementation of app installation. Is there someone else who could review this?
Comment on attachment 8408626 [details] [diff] [review]
Patch

(In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #1)
> I don't really know anything about our Mac implementation of app
> installation. Is there someone else who could review this?

Let's ask Felipe.
Attachment #8408626 - Flags: review?(tabraldes) → review?(felipc)
Comment on attachment 8408626 [details] [diff] [review]
Patch

Review of attachment 8408626 [details] [diff] [review]:
-----------------------------------------------------------------

Why pass this.zipFile as a parameter instead of making _getIcon directly use it?
Posted patch PatchSplinter Review
(In reply to :Felipe Gomes from comment #3)
> Comment on attachment 8408626 [details] [diff] [review]
> Patch
> 
> Review of attachment 8408626 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Why pass this.zipFile as a parameter instead of making _getIcon directly use
> it?

That's right!
Assignee: nobody → mar.castelluccio
Attachment #8408626 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8408626 - Flags: review?(felipc)
Attachment #8410642 - Flags: review?(felipc)
Attachment #8410642 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/fcdca8a9cda1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Marco, do you need testing for this before Firefox 31 is released?
Flags: needinfo?(mar.castelluccio)
I've built a basic test (http://mxr.mozilla.org/mozilla-central/source/toolkit/webapps/tests/test_packaged_icons.xul), so I think this is covered.
Flags: needinfo?(mar.castelluccio)
Flags: in-testsuite+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.