Closed
Bug 998210
Opened 10 years ago
Closed 10 years ago
check logging is enabled before use
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jtd, Assigned: jtd)
Details
Attachments
(1 file)
3.98 KB,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
A few places in the gfx font code use 'if (MOZ_UNLIKELY(log))' to avoid calling PR_LOG in a time-sensitive codepath. However, a log module object is always created, the log level needs to be checked to see if the log is actually enabled (it's only enabled in a rare debugging situation).
Assignee | ||
Comment 1•10 years ago
|
||
Solution is just to call PR_LOG_TEST in a few cases.
Attachment #8408796 -
Flags: review?(m_kato)
Updated•10 years ago
|
Attachment #8408796 -
Flags: review?(m_kato) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Pushed to inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/f180f4ba7a98
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f180f4ba7a98
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•