Closed Bug 998210 Opened 10 years ago Closed 10 years ago

check logging is enabled before use

Categories

(Core :: Graphics: Text, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jtd, Assigned: jtd)

Details

Attachments

(1 file)

A few places in the gfx font code use 'if (MOZ_UNLIKELY(log))' to avoid calling PR_LOG in a time-sensitive codepath.  However, a log module object is always created, the log level needs to be checked to see if the log is actually enabled (it's only enabled in a rare debugging situation).
Solution is just to call PR_LOG_TEST in a few cases.
Attachment #8408796 - Flags: review?(m_kato)
Attachment #8408796 - Flags: review?(m_kato) → review+
https://hg.mozilla.org/mozilla-central/rev/f180f4ba7a98
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.