998270 - Subfolders within a Favourites folder

Status: NEW

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[Ian James Vale]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

Selected a folder, with subfolders, to be a favourites folder.


Actual results:

The parent folder was visible in the favourites pane, but the subfolders within it weren't.


Expected results:

The parent folder would have a triangle icon for showing subfolders within it from within the favourites pane.

It may be that this is a feature that a user can choose to select on creating a favourites folder - that is, they can check a box for 'show subfolders for this favourites folder' to allow, or leave it clear to just have the parent folder on its own.

Comment 1

[:aceman]

We switched to hierarchical view for Favorite mode in bug 533775 so this would be possible. It just needs to tweak the filter function to include folders that have a favorite parent.

But do we actually want this?

Comment 2

[Magnus Melin [:mkmelin]]

Definitely IMO! This is one of the main things limiting the usefulness of favorite mode.

Comment 3

[Josiah Bruner [:jsbruner]]

If a user can toggle both options, then yes, let's definitely do this.

Comment 4

[Magnus Melin [:mkmelin]]

Isn't the toggle in this case that the user simply clicks open (expands) the folder hierarchy of the fav folder?

Comment 5

[Josiah Bruner [:jsbruner]]

Yes. :)

Comment 6

[Blake Winton (:bwinton) (:☕️)]

I agree with Josiah and Magnus.

Comment 7

[:aceman]

OK, I'll check out what needs to be done.

Comment 8

[Magnus Melin [:mkmelin]]

Should be around here: https://searchfox.org/comm-central/rev/b0bfd7596c6d6f0ef580ce2c9cd680b2e6ca0bf1/mail/base/content/folderPane.js#2277