Implement layout of block padding for box-decoration-break:clone

RESOLVED FIXED in mozilla32

Status

()

enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

unspecified
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

Assignee

Description

5 years ago
No description provided.
Posted file testcase
Assignee

Comment 4

5 years ago
GetConsumedHeight()/GetEffectiveComputedHeight() makes the assumption that
only the first-in-flow has top border+padding and that later continuations
has no vertical border+padding.  This is obviously wrong for b-d-b:clone.
We need to use GetContentRectRelativeToSelf here instead which uses
GetSkipSides internally.

This change is idempotent for b-d-b:slice, but may break some b-d-b:clone
tests that depend on this bug; I'll fix those tests in a later patch here.
I've pushed this part only to verify that:
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=0bda084c7f4a
Attachment #8409367 - Flags: review?(cam)
Assignee

Comment 5

5 years ago
nsBlockReflowState also had a few assumptions that are wrong for b-d-b:clone.
Attachment #8409368 - Flags: review?(cam)
Assignee

Comment 8

5 years ago
Comment on attachment 8409367 [details] [diff] [review]
part 0, Fix ConsumedHeight calculations so that they will work also for box-decoration-break:clone.

See patch descriptions in comments above.
Attachment #8409367 - Flags: review?(cam) → review?(roc)
Assignee

Updated

5 years ago
Attachment #8409368 - Flags: review?(cam) → review?(roc)
Assignee

Updated

5 years ago
Attachment #8409369 - Flags: review?(cam) → review?(roc)
You need to log in before you can comment on or make changes to this bug.