998535 - Implement layout of block padding for box-decoration-break:clone

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, enhancement)

Comment 1

[Robert Utasi [:hunboy]]

Attachment: testcase

Comment 2

[Robert Utasi [:hunboy]]

Attachment: ref case - graphical presentation - (clone)

Comment 3

[Robert Utasi [:hunboy]]

Attachment: ref case - graphical presentation - (default slice)

Comment 4

[Mats Palmgren (inactive)]

Attachment: part 0, Fix ConsumedHeight calculations so that they will work also for box-decoration-break:clone.

GetConsumedHeight()/GetEffectiveComputedHeight() makes the assumption that
only the first-in-flow has top border+padding and that later continuations
has no vertical border+padding.  This is obviously wrong for b-d-b:clone.
We need to use GetContentRectRelativeToSelf here instead which uses
GetSkipSides internally.

This change is idempotent for b-d-b:slice, but may break some b-d-b:clone
tests that depend on this bug; I'll fix those tests in a later patch here.
I've pushed this part only to verify that:
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=0bda084c7f4a

Comment 5

[Mats Palmgren (inactive)]

Attachment: part 1, Apply GetSkipSides to block border+padding to make it for work for box-decoration-break:clone.

nsBlockReflowState also had a few assumptions that are wrong for b-d-b:clone.

Comment 6

[Mats Palmgren (inactive)]

Attachment: part 2, Reftests for box-decoration-break:clone that use block border/padding. Tweak an older test that depended on b-d-b:clone not working correctly for blocks.

https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=e526ed984554
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=91e12c6617c5

Comment 7

[Robert Utasi [:hunboy]]

Attachment: ref case - graphical presentation - (clone with linear-gradient)

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 8409367 [details] [diff] [review]
part 0, Fix ConsumedHeight calculations so that they will work also for box-decoration-break:clone.

See patch descriptions in comments above.

Comment 9

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0aefe597c1da
https://hg.mozilla.org/integration/mozilla-inbound/rev/63325b58cde5
https://hg.mozilla.org/integration/mozilla-inbound/rev/32a55e9008ba

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0aefe597c1da
https://hg.mozilla.org/mozilla-central/rev/63325b58cde5
https://hg.mozilla.org/mozilla-central/rev/32a55e9008ba