Closed Bug 998723 Opened 10 years ago Closed 10 years ago

Missing plural forms for mergeActionButtonLabel in Contacts Matcher app

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kscanne, Assigned: flod)

Details

Attachments

(1 file)

Pull request on Github
46 bytes, text/x-github-pull-request
jmcf
: review+
Details | Review 
There are only plural forms "[zero]", "[one]", and "[other]".   Several languages need the full range of possible forms, including "[two]", "[few]", and "[many]".

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/locales/matcher/matcher.en-US.properties#L15
Assignee: nobody → francesco.lodolo
OS: Mac OS X → All
Hardware: x86 → All
Attached file Pull request on Github — 

        Attachment #8419420 -
        Flags: review?(jmcf)

    
    

    
  
Comment on attachment 8419420 [details] [review]
Pull request on Github

LGTM

thanks

        Attachment #8419420 -
        Flags: review?(jmcf) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/05ab2b307068031e94308b5c1d7a0fd903ccb0a6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: