Closed
Bug 998741
Opened 10 years ago
Closed 10 years ago
Windows XULRunner builds fail with nsISupportsUtils.h(136) : error C2338: don't use CallQueryInterface for compile-time-determinable casts
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox31+ fixed)
VERIFIED
FIXED
mozilla31
People
(Reporter: philor, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
918 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Alas, apparently we once again aren't going to manage to kill off XULRunner, so it's going to be a hidden tier 2 tier 1 release deliverable we don't build visibly for yet another ESR round, and we need to fix it to actually build on Windows. It's been busted for weeks, either left over from when ehsan broke it on all platforms, or coincidentally broken while it was broken, or maybe it was right after, I don't remember anymore. https://tbpl.mozilla.org/php/getParsedLog.php?id=38139048&tree=Mozilla-Central winEmbed.cpp c:\builds\moz2_slave\m-cen-w32-xr-ntly-000000000000\build\obj-firefox\dist\include\nsISupportsUtils.h(136) : error C2338: don't use CallQueryInterface for compile-time-determinable casts c:/builds/moz2_slave/m-cen-w32-xr-ntly-000000000000/build/embedding/tests/winEmbed/winEmbed.cpp(1080) : see reference to function template instantiation 'nsresult CallQueryInterface<nsIWebBrowserChrome,nsIWebBrowserChrome>(T *,DestinationType **)' being compiled with [ T=nsIWebBrowserChrome, DestinationType=nsIWebBrowserChrome ] c:/builds/moz2_slave/m-cen-w32-xr-ntly-000000000000/build/config/rules.mk:1004: recipe for target 'winEmbed.obj' failed
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8409484 -
Flags: review?(benjamin)
Updated•10 years ago
|
Attachment #8409484 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/418c50532eea
Assignee: nobody → ehsan
https://hg.mozilla.org/mozilla-central/rev/418c50532eea
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox31:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Assignee | ||
Comment 5•10 years ago
|
||
It would be nice if someone could please test to make sure there are no outstanding issues.
Reporter | ||
Comment 6•10 years ago
|
||
But given that absolutely nobody made a peep during the weeks we weren't building, the audience for this job is apparently "philor, releng on release branches only, only because they have to build it for releases, and hypothetical people who may or may not exist but who only consume release builds, never nightlies." Once upon a time there was one consumer of nightlies, WeirdAl, but I think we finally convinced him that we will kill XULRunner, actively or passively, but kill it we will, and he should look elsewhere. We'll see how I do at remembering I need to look at https://tbpl.mozilla.org/?showall=1&rev=ac376a4e8174&jobname=xulrunner (likely to be tomorrow's nightly rev) with a fresh eye.
Reporter | ||
Comment 7•10 years ago
|
||
It builds; we'll probably find out whether or not it runs in 17.5 weeks.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to comment #7) > It builds; we'll probably find out whether or not it runs in 17.5 weeks. Haha, thanks Phil!
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•