Closed
Bug 998759
Opened 10 years ago
Closed 10 years ago
Remove chai.js copying when running make update-common
Categories
(Firefox OS Graveyard :: Gaia::TestAgent, defect)
Tracking
(b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
People
(Reporter: rickychien, Assigned: rickychien)
References
Details
(Keywords: regression)
Attachments
(1 file)
Every time I run "make update-common" to sync my test-agent chagnes will also copy chai.js from node_modules, but I think this should not happen. Actually, our test-agent app use old version chai and it will arise a lot of test fails if moving to new version. It would be more convenient if we remove this.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8409422 -
Flags: review?(yurenju.mozilla)
Comment 2•10 years ago
|
||
Note that I have bug 991663 to upgrade mocha/chai/etc. In the future we should have the good one but you're right that some tests are failing with it :( How comes that it doesn't fail on Travis?
Assignee | ||
Comment 3•10 years ago
|
||
Really? Upgrade chai even pass on Travis? hmm... sounds weird I believe adding sandbox for each test file will fix local and Travis inconsistent issue. So I don't have any idea about this.
Comment 4•10 years ago
|
||
Note that "sandbox for each test" has already landed :)
Comment 5•10 years ago
|
||
Comment on attachment 8409422 [details] [review] Gaia PR r=yurenju because using same version of chai between test-agent dependency and app unit test is not necessary. (but it would be good if we upgrade our chai version on another bug)
Attachment #8409422 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Merged. https://github.com/mozilla-b2g/gaia/commit/616adbea1e2b52d0399aa35312755a723e94674b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
And I know why it doesn't fail on travis: travis runs "make common-install", but not "make update-common". Should we make it run "make update-common" instead ? "common-install" is practically a noop these days... What do you think Yuren?
Flags: needinfo?(yurenju.mozilla)
Comment 8•10 years ago
|
||
yes we should use update-common, but I don't know why it named common-install, it shoud be named common-check or something...
Flags: needinfo?(yurenju.mozilla)
Comment 9•10 years ago
|
||
because it used to run "npm install" in the test-agent directory, but this was removed around one month ago :)
Comment 10•10 years ago
|
||
This was a regression from bug 976152 which is in v1.4 so I uplifted this to v1.4 as well with a=tests. v1.4: 62ec84411ecf94dcb80921631e04bc7db25625bb
Blocks: 976152
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•