998760 - Crash on xpcshell-test shutdown for test_bug759324.js | application crashed [@ mozilla::storage::Connection::~Connection()]

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:487
<<<<<<<
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/calendar/test/unit/test_bug759324.js | application crashed [@ mozilla::storage::Connection::~Connection()]
Crash dump filename: /tmp/tmpgteFos/1eb15512-1b13-9a45-715e447d-75885f51.dmp
Operating system: Linux
                  0.0.0 Linux 3.2.0-23-generic-pae #36-Ubuntu SMP Tue Apr 10 22:19:09 UTC 2012 i686
CPU: x86
     GenuineIntel family 6 model 45 stepping 7
     1 CPU

Crash reason:  SIGSEGV
Crash address: 0x0

Thread 0 (crashed)
 0  libxul.so!mozilla::storage::Connection::~Connection() [mozStorageConnection.cpp:fd7c870fa960 : 486 + 0x19]
    eip = 0xb3e487fc   esp = 0xbf9db590   ebp = 0xbf9db5a8   ebx = 0xb7204f50
    esi = 0x0a05c3b8   edi = 0x00000000   eax = 0x00000000   ecx = 0xb35038ac
    edx = 0x00000000   efl = 0x00010282
    Found by: given as instruction pointer in context



The cleanup functions seem to not be called here, I have a patch that might fix it, here is a try run. Note that this run might contain other failures related to bug 680203

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=7e7361d5918b

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This does indeed fix the issue, here is the patch.

Comment 2

[Mohit Kanwal [:redDragon]]

Comment on attachment 8409427 [details] [diff] [review]
Fix - v1

Review of attachment 8409427 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/7f9651bfe1a4