998767 - FOR text isn't shown in a German article

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Thomas Schwecherl]

I reviewed article https://support.mozilla.org/de/kb/lesezeichen-aus-internet-explorer-importieren today.

At the beginning of the article there's the FOR paragraph:
{for not win}{note}'''Dieser Artikel trifft nur auf Windows zu.'''{/note}{/for}
which says, that the content is applicable on Windows only.

But this paragraph isn't visible on Linux or Mac.
Tested with Firefox 29 Beta on Ubuntu Linux.

Comment 1

[Joni Chan]

It's not showing up for me either on Mac or Ubuntu. Let's see if Ricky or Kadir can help us.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

My suggestion would be to do what the English version did: `{for mac,linux}`... They must've had a reason. win is a special case for us. We probably don't support "not win" because of that.

Comment 3

[Thomas Schwecherl]

I changed it in that way Ricky suggested.
But I think that's only a workaround, not a solution. If "win" is possible, why not "not win" ...

Comment 4

[Michael Cooper [:mythmon]]

Thomas: This was just a logic bug in showfor. I tried to deal with "not win", but I screwed up last time. I've put in a PR to fix the problem, and added an automated test case to prevent this from happening again in the future. Thanks for pointing this out!

PR: https://github.com/mozilla/kitsune/pull/1922

Sprint details: I did this in my downtime in about half an hour => 0 points, and I'm tossing it in the current sprint.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d145091b114d3f88efdf460e0c2e9640fed3718c

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

deployed to prod.

Comment 7

[Thomas Schwecherl]

Mike, thanks for fixing that!